chore: add support for the openebs plugin #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaisedias
force-pushed
the
support-new-plugins
branch
3 times, most recently
from
e225ec8
to
50a053d
Compare
r1jt
reviewed
Nov 14, 2024
r1jt
reviewed
Nov 14, 2024
r1jt
approved these changes
Nov 14, 2024
the openebs plugin supercedes the mayastor
plugin.
However it is not a dropin replacement.
It is functional for all openebs IO engines,
and stem commands needs to further qualify
which IO engine the command is for.
At present invocations of the plugin in the
code base only exist for mayastor.
Refactor by adding functions
- GetMayastorPluginCmd returns and exec cmds with the
correct argument list
- GetMayastorPluginCmdString - needed for invocation of
support shell scripts using the plugin
For the argument list is determined by name.
The assumption is that if the plugin name is
not kubectl-mayastor then it is the new plugin.
Refactor to replace most uses of GetPluginPath,
the exceptions being
- upgrade
- plugin version check commands
Also add support to create a config map for mayastor
diskpools.
Compatibilty with kubectl-mayastor is maintained
Signed-off-by: Blaise Dias <[email protected]>
Add support for specifying the full path to the kubectl plugin. Use that in preference over plugin dir + configured kubectl plugin name. This gives invoking scripts more flexibility. Signed-off-by: Blaise Dias <[email protected]>
Replace use of GetMayastorPluginCmdString with GetMayastorPluginCmd().String() Signed-off-by: Blaise Dias <[email protected]>
blaisedias
force-pushed
the
support-new-plugins
branch
from
78e8313
to
8a57b1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the openebs plugin supercedes the mayastor
plugin.
However it is not a dropin replacement.
It is functional for all openebs IO engines,
and stem commands needs to further qualify
which IO engine the command is for.
At present invocations of the plugin in the
code base only exist for mayastor.
Refactor by adding functions
correct argument list
support shell scripts using the plugin
For the argument list is determined by name.
The assumption is that if the plugin name is
not kubectl-mayastor then it is the new plugin.
Refactor to replace most uses of GetPluginPath,
the exceptions being
Also add support to create a config map for mayastor
diskpools.
Compatibilty with kubectl-mayastor is maintained