chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml
#685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <[email protected]>
niladrih
added a commit
to niladrih/node-disk-manager
that referenced
this pull request
Feb 9, 2023
Signed-off-by: Niladri Halder <[email protected]>
niladrih
added a commit
that referenced
this pull request
Feb 9, 2023
* chore: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml` At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <[email protected]> Signed-off-by: Niladri Halder <[email protected]> * chore(changelog): update changelog with PR #685's changes Signed-off-by: Niladri Halder <[email protected]> --------- Signed-off-by: Eng Zer Jun <[email protected]> Signed-off-by: Niladri Halder <[email protected]> Co-authored-by: Eng Zer Jun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Why is this PR required? What issue does it fix?:
The package
github.com/ghodss/yamlis no longer actively maintained. See discussion in ghodss/yaml#80 and ghodss/yaml#75sigs.k8s.io/yamlis a permanent fork ofghodss/yamland is actively maintained by Kubernetes SIG.What this PR does?:
Replace
github.com/ghodss/yamlwithsigs.k8s.io/yaml.Does this PR require any upgrade changes?:
No.
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Checklist:
<type>(<scope>): <subject>