Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update background color of Left Menu components (both DragDropPanel and MUIDragDropPanel) to make consistent with background color of entire Left Menu #263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnwage
Copy link
Contributor

Description

Please describe the issue of the pull request and the changes

  • Update background color of Left Menu components (both DragDropPanel and MUIDragDropPanel) to make consistent with background color of entire Left Menu

Type of Change

Please check the options that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has the Changes Been Tested?

  • Visually tested through GUI and user experience.

Checklist:

  • My code follows the style guidelines of this project
  • Changes included in this pull request covers minimal topic
  • I have performed a self-review of my code
  • I have commented my code properly, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

image
image

…nd MUIDragDropPanel) to make consistent with background color of entire Left Menu
Copy link

@noahFavelo noahFavelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that it matters much, but I reviewed what these changes accomplish and I like how it looks without the weird black headers even though i thought it looked ok at first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants