Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label to serial nodes #1484

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Add label to serial nodes #1484

merged 1 commit into from
Nov 17, 2024

Conversation

akalenyu
Copy link
Contributor

@akalenyu akalenyu commented Nov 11, 2024

Adding a label in order to be able to filter tests decorated with Serial.

Fixes #1483

@akalenyu
Copy link
Contributor Author

@onsi Are the failures caused by the PR?

@onsi
Copy link
Owner

onsi commented Nov 14, 2024

yes - this line:

https://github.com/onsi/ginkgo/blob/master/integration/timeline_test.go#L141

needs to changed to a full timeline [Serial]\n

you should be able to ginkgo -r -p from the root directory and see it all go green. Every now and then an integration spec will flake on a slow machine but they are generally pretty reliable so if you see a failure it’s probably the new code. In this case adding Serial as a label changed the output and we’ll need to update the test.

@akalenyu
Copy link
Contributor Author

yes - this line:

https://github.com/onsi/ginkgo/blob/master/integration/timeline_test.go#L141

needs to changed to a full timeline [Serial]\n

you should be able to ginkgo -r -p from the root directory and see it all go green. Every now and then an integration spec will flake on a slow machine but they are generally pretty reliable so if you see a failure it’s probably the new code. In this case adding Serial as a label changed the output and we’ll need to update the test.

Added. I couldn't understand who sets the serial decorator on this timeline test though

Adding a label in order to be able to filter tests decorated with `Serial`.

Signed-off-by: Alex Kalenyuk <[email protected]>
@onsi onsi merged commit 0fcaa08 into onsi:master Nov 17, 2024
6 checks passed
@onsi
Copy link
Owner

onsi commented Nov 17, 2024

yay! that worked. will cut a release soon

@akalenyu
Copy link
Contributor Author

yay! that worked. will cut a release soon

hey, are you planning to cut a release?

akalenyu added a commit to akalenyu/kubevirt that referenced this pull request Nov 21, 2024
@onsi
Copy link
Owner

onsi commented Nov 21, 2024

done!

@akalenyu
Copy link
Contributor Author

done!

thank you!

akalenyu added a commit to akalenyu/kubevirt that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to filter for tested marked with "Serial"
2 participants