-
-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label to serial nodes #1484
Conversation
@onsi Are the failures caused by the PR? |
yes - this line: https://github.com/onsi/ginkgo/blob/master/integration/timeline_test.go#L141 needs to changed to you should be able to |
7551e70
to
578e3f4
Compare
Added. I couldn't understand who sets the serial decorator on this timeline test though |
578e3f4
to
be454af
Compare
Adding a label in order to be able to filter tests decorated with `Serial`. Signed-off-by: Alex Kalenyuk <[email protected]>
be454af
to
381dda3
Compare
yay! that worked. will cut a release soon |
hey, are you planning to cut a release? |
onsi/ginkgo#1484 Signed-off-by: Alex Kalenyuk <[email protected]>
done! |
thank you! |
onsi/ginkgo#1484 Signed-off-by: Alex Kalenyuk <[email protected]>
Adding a label in order to be able to filter tests decorated with
Serial
.Fixes #1483