Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing commas #1475

Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix: missing commas #1475

merged 1 commit into from
Nov 5, 2024

Conversation

monteiro-renato
Copy link
Contributor

No description provided.

@onsi
Copy link
Owner

onsi commented Nov 4, 2024

hey thanks for all of these tweaks. this one no longer merges in, would you be up for rebasing it?

also - while i appreciate separating the work into tiny chunks. a single PR with all these fixes would have worked fine for me as well.

@monteiro-renato
Copy link
Contributor Author

Hey 👋
I've fixed the merge conflict now.

Sorry for the noise! 😅
For simple tweaks like these I usually just edit the files directly via GitHub UI as I find them.
I will try to compile all into a single PR if I find more tweaks to be made.

@onsi
Copy link
Owner

onsi commented Nov 5, 2024

thanks! i appreciate you taking the time to fix these things!

@onsi onsi merged commit 21765a2 into onsi:master Nov 5, 2024
6 checks passed
@monteiro-renato monteiro-renato deleted the patch-6 branch November 5, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants