-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMDBUF] Fix incorrect handling of shared local mem args in CUDA/HIP #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Bensuo
commented
Oct 29, 2024
- Fix handling of local mem args in CUDA/HIP for command buffer update
- Add conformance tests which check updating local memory args and work size
github-actions
bot
added
conformance
Conformance test suite issues.
cuda
CUDA adapter specific issues
hip
HIP adapter specific issues
command-buffer
Command Buffer feature addition/changes/specification
labels
Oct 29, 2024
DPC++ PR: intel/llvm#15920 |
EwanC
reviewed
Oct 30, 2024
test/conformance/exp_command_buffer/update/local_memory_update.cpp
Outdated
Show resolved
Hide resolved
Bensuo
force-pushed
the
ben/cmdbuf-local-arg-fix
branch
2 times, most recently
from
October 30, 2024 17:39
b9eb5da
to
31c441e
Compare
github-actions
bot
added
specification
Changes or additions to the specification
experimental
Experimental feature additions/changes/specification
labels
Oct 30, 2024
Bensuo
force-pushed
the
ben/cmdbuf-local-arg-fix
branch
from
October 30, 2024 17:43
31c441e
to
5e9aa0f
Compare
Code change look fine to me, but there's some HIP command-buffer CTS tests failing in CI which might not be spurious |
Bensuo
force-pushed
the
ben/cmdbuf-local-arg-fix
branch
3 times, most recently
from
October 31, 2024 19:15
2edb77c
to
986de59
Compare
- Fix handling of local mem args in CUDA/HIP - Add conformance tests which check updating local memory args and work size - Change argSize in ur_exp_command_buffer_update_value_arg_desc_t to be size_t in line with urKernelSetArg
Bensuo
force-pushed
the
ben/cmdbuf-local-arg-fix
branch
from
October 31, 2024 19:23
986de59
to
b7d78ba
Compare
EwanC
approved these changes
Nov 1, 2024
@oneapi-src/unified-runtime-maintain This is ready for review, there is a CUDA E2E CI fail but that's not reflected in the CI for the matching DPC++ PR which is green and also seems to be in other open PRs like #2263
|
callumfare
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
command-buffer
Command Buffer feature addition/changes/specification
conformance
Conformance test suite issues.
cuda
CUDA adapter specific issues
experimental
Experimental feature additions/changes/specification
hip
HIP adapter specific issues
ready to merge
Added to PR's which are ready to merge
specification
Changes or additions to the specification
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.