-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: aarch64: Skip Jit uni reorder if 4d matrix and zero point is defined #2207
base: main
Are you sure you want to change the base?
Conversation
src/cpu/aarch64/jit_uni_reorder.cpp
Outdated
bool has_zero_point | ||
= !_pd->attr()->zero_points_.has_default_values(DNNL_ARG_FROM) | ||
|| !_pd->attr()->zero_points_.has_default_values(DNNL_ARG_TO); | ||
if (src_md->ndims == 4 && has_zero_point) { return status::unimplemented; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this implementation is a copy-paste of existing one for x64, I suggest moving the check either into prb_init
or into tr::kernel_t::desc_init
.
As for the check itself, is it only ndims=4? Or any ndims is affected by this limitation?
If the latter, then existing testing coverage should be enough to trigger the error and probably might not be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review, I have moved the check to prb_init
.
As far as I can tell, the issue seems to be only ndims=4. I have run test_benchdnn_modeC_reorder_ci_cpu
which passes so I would assume that the other ndims are okay
77a5134
to
f267040
Compare
…fined Change-Id: I837a8f66d8e8f6afce8e944416db96987e95abac
f267040
to
46bea4a
Compare
Hi @Ryo-not-rio, @theComputeKid, @dzarukin |
@Shreyas-fuj Thanks for looking into it. Much appreciated. |
Description
Jit:uni reorders for certain 4d matrices are returning incorrect results when the src zero point != 0. A guard has been added to skip jit uni reorders for any 4d matrices where src zero point != 0 so the simple:any implementation will be used. A new testcase has also been added to benchdnn.
Reproduction:
General
make test
andmake test_benchdnn_*
) pass locally for each commit?Bug fixes