Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding image to venue page #257

Merged
merged 4 commits into from
Jun 20, 2020
Merged

Adding image to venue page #257

merged 4 commits into from
Jun 20, 2020

Conversation

PatoViera
Copy link
Contributor

No description provided.

@welcome
Copy link

welcome bot commented Jun 19, 2020

Thank You Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. http://doi.org/10.5281/zenodo.3332808)
💖 Thanks for opening this pull request! 💖 We really appreciate your time and effort to contribute to the project. If you are trying to add your contribution to our Venue page, please make sure you have read our instructions and have shared all relevant details in your pull request. The OHBM Brainhack webteam might be a bit busy right now but we will have a look at your suggestion very quickly.

@Remi-Gau
Copy link
Contributor

Hey @PatoViera

Thanks for opening this pull request

You still need to edit the _data/venue.yml file. By adding these lines for example.

-
  name: "YOUR NAME"
  image: img/venue/IMG_0056.jpg

Add your name there and commit the change to your branch, push it and it will update your pull request here :)

_data/venue.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!
This all looks good to me.
I will merge your pull request now.
The website takes a few minutes to update but your image should be there soon.

@Remi-Gau Remi-Gau merged commit 50a57aa into ohbm:master Jun 20, 2020
@welcome
Copy link

welcome bot commented Jun 20, 2020

Congratulations Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. http://doi.org/10.5281/zenodo.3332808)
Congrats on merging your first pull request! 🎉 We here at OHBM Brainhack team really appreciate your contribution! 💖 Go ahead and share your your first merge with your colleagues, you got yourself this brag right! 😄 🎁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants