Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] owl-vision: vscode extension initial commit #1545

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

BastienFafchamps
Copy link
Contributor

@BastienFafchamps BastienFafchamps commented Oct 19, 2023

Owl Vision is a vscode extension that improves owl developpement by adding
syntax highlights in templates and commands to easly navigate between
components and templates.

It also adds a Component snippet.

The following commands have been added:

  • Owl Vision: Find Template:
    • If the cursor is on a template name, finds the corresponding template.
    • If the cursor is on a component, finds the template of the selected component.
  • Owl Vision: Find Component: Finds the selected component definition.
  • Owl Vision: Switch: Finds the corresponding template or component
    depending on the current file.
  • Owl Vision: Switch Besides: Finds the corresponding template or component
    depending on the current file and opens it besides.

The following settings have been added to make the extension more configurable:

  • owl-vision.include: Glob filter for files to include while searching.
  • owl-vision.exclude: Glob filter for files to exclude while searching.

The .gitignore files has also been updated to accommodate to vscode extension development.

@BastienFafchamps BastienFafchamps force-pushed the owl-vision-init branch 9 times, most recently from d8fff59 to fc511af Compare October 19, 2023 14:45
@BastienFafchamps BastienFafchamps marked this pull request as ready for review October 20, 2023 14:42
Copy link
Contributor

@sdegueldre sdegueldre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these comments are things that can be adressed later, the one thing that I'd like to be fixed before merging is the indents being tabs as this would generate a lot of diff in a subsequent PR.

tools/owl-vision/README.md Outdated Show resolved Hide resolved
tools/owl-vision/src/definiton_providers.ts Outdated Show resolved Hide resolved
tools/owl-vision/src/search.ts Outdated Show resolved Hide resolved
tools/owl-vision/src/search.ts Outdated Show resolved Hide resolved
tools/owl-vision/src/search.ts Outdated Show resolved Hide resolved
tools/owl-vision/src/search.ts Outdated Show resolved Hide resolved
tools/owl-vision/src/search.ts Outdated Show resolved Hide resolved
tools/owl-vision/src/search.ts Outdated Show resolved Hide resolved
tools/owl-vision/src/utils.ts Outdated Show resolved Hide resolved
tools/owl-vision/src/search.ts Outdated Show resolved Hide resolved
@BastienFafchamps BastienFafchamps force-pushed the owl-vision-init branch 3 times, most recently from d69579e to b7d4fc6 Compare October 23, 2023 13:15
Owl Vision is a vscode extension that improves owl developpement by adding
syntax highlights in templates and commands to easly navigate between
components and templates.

It also adds a Component snippet.

Commands:

* `Owl Vision: Find Template`:
    - If the cursor is on a template name, finds the corresponding template.
    - If the cursor is on a component, finds the template of the selected component.
* `Owl Vision: Find Component`: Finds the selected component definition.
* `Owl Vision: Switch`: Finds the corresponding template or component
    depending on the current file.
* `Owl Vision: Switch Besides`: Finds the corresponding template or component
    depending on the current file and opens it besides.

Settings:

* `owl-vision.js.include`: Javascript files to include in search.
* `owl-vision.js.exclude`: Javascript files to exclude in search.
* `owl-vision.xml.include`: XML files to include in search.
* `owl-vision.xml.exclude`: XML files to exclude in search.
@ged-odoo ged-odoo merged commit 166cada into odoo:master Oct 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants