-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] website: introduce s_split_intro
snippet
#175321
base: master
Are you sure you want to change the base?
[IMP] website: introduce s_split_intro
snippet
#175321
Conversation
242928a
to
44c260e
Compare
s_connections
s_connection
snippet
926fabb
to
212e982
Compare
212e982
to
23bef06
Compare
0021db9
to
12b72a7
Compare
s_connection
snippets_connection
snippet
12b72a7
to
9c828ad
Compare
s_connection
snippets_split_intro
snippet
9c828ad
to
de12ef4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @chgo-odoo, here are some comments
de12ef4
to
c391311
Compare
ty @anso-odoo can you check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicking for you. After that it looks like it will be fine 👍
c391311
to
9e89d70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
583ea27
to
be78e80
Compare
This commit introduces a new snippet named `s_split_intro`. task-4077616 part of task-4077427
be78e80
to
3526a9e
Compare
Hi @chgo-odoo , just wondering why we don't left a blank link for "Discover more" (all intro snippets use this value as default link) instead of using /contactus Nice snippet 🎉 |
This PR introduces a new snippet named
s_split_intro
.s_split_intro
snippet design-themes#876task-4077616
Part of task-4077427
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr