Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] figure: crash on deleting dragged figure #5223

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[FIX] figure: crash on deleting dragged figure #5223

wants to merge 1 commit into from

Conversation

hokolomopo
Copy link
Contributor

Description

There was a traceback if a figure was deleted while being dragged.

Task: 4329240

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@hokolomopo
[FIX] figure: crash on deleting dragged figure
d76d345 
There was a traceback if a figure was deleted while being dragged.

Task: 4329240
@robodoo
Copy link
Collaborator

robodoo commented Nov 18, 2024

Pull request status dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hokolomopo @robodoo