[IMP] *: replace ir.model.data by cloc_exclude entries in manifest #267

dhrs-odoo · 2024-10-09T12:26:08Z

In this commit, we replace all entries of ir.model.data by adding the specific files into the cloc_exclude list in the manifest. This will automatically create the necessary ir.model.data. Also, the demo files that could impact the cloc, mainly website views, are now excluded as well.

Task-4243531

vava-odoo

Please update the test linked to the cloc: remove the if-clause at the beginning and modify the error message

fitness/__manifest__.py

photography/__manifest__.py

jaeschwa

Good work needs some adjustments

certification_organism/__manifest__.py

coal_petroleum/__manifest__.py

electronic_store/__manifest__.py

eyewear_shop/__manifest__.py

industry_real_estate/__manifest__.py

solar_installation/__manifest__.py

tests/test_generic/tests/test_industry_requirements.py

jaeschwa

Good job, could you just ensure consistency with the name of the file so they are all named website_view.xml. Thanks

industry_lawyer/__manifest__.py

non_profit_organization/__manifest__.py

dhrs-odoo · 2024-10-14T08:40:48Z

Hello @jaeschwa
Done with the changes
Thank You

vava-odoo

Stopping here, as I don't understand why you moved all website views to demo

agriculture_shop/data/website_view.xml

architects/demo/website_view.xml

art_craft/data/custom_view.xml

tests/test_generic/tests/test_industry_requirements.py

robodoo · 2024-11-19T12:01:44Z

robodoo · 2024-11-19T12:01:45Z

@dhrs-odoo I didn't know about this PR and had to retrieve its information, you may have to re-approve it as I didn't see previous commands.

dhrs-odoo · 2024-11-20T09:19:21Z

Hello @vava-odoo
I have incorporated the changes
Please have a look at it once you are free
Thank You 😇

agriculture_shop/demo/website_view.xml

tests/test_generic/tests/test_industry_requirements.py

vava-odoo

I stop the review here, please apply the comments to all other modules before another review, please. Thanks!

agriculture_shop/__manifest__.py

agriculture_shop/demo/website_view.xml

architects/__manifest__.py

architects/demo/website_theme_apply.xml

art_craft/__manifest__.py

bike_leasing/__manifest__.py

bike_leasing/demo/website_view.xml

dhrs-odoo · 2024-11-25T06:37:57Z

Hello @vava-odoo
I have completed the changes
Can you please have a look at it once you are free
Thanks and Have a great day ahead 😇

vava-odoo

Last small comments. Could you also rebase your PR to make sure we don't miss other modules to update. Thanks!

corporate_gifts/data/website_menu.xml

eyewear_shop/__manifest__.py

industry_restaurant/demo/website_view.xml

micro_brewery/demo/website_theme_apply.xml

micro_brewery/demo/website_view.xml

All requests applied

vava-odoo

@robodoo r+ squash

robodoo · 2024-11-25T12:19:30Z

Merge method set to squash.

In this commit, we replace all entries of ir.model.data by adding the specific files into the cloc_exclude list in the manifest. This will automatically create the necessary ir.model.data. Also, the demo files that could impact the cloc, mainly website views, are now excluded as well. Task-4243531 closes #307 Forward-port-of: #267 Signed-off-by: Vallaeys Valentin (vava) <[email protected]> Signed-off-by: Dhrumil Shah (dhrs) <[email protected]>

In this commit, we replace all entries of ir.model.data by adding the specific files into the cloc_exclude list in the manifest. This will automatically create the necessary ir.model.data. Also, the demo files that could impact the cloc, mainly website views, are now excluded as well. Task-4243531 closes odoo#267 Signed-off-by: Vallaeys Valentin (vava) <[email protected]>

vava-odoo requested changes Oct 9, 2024

View reviewed changes

fitness/__manifest__.py Outdated Show resolved Hide resolved

photography/__manifest__.py Show resolved Hide resolved

jaeschwa previously requested changes Oct 10, 2024

View reviewed changes

dhrs-odoo force-pushed the 18.0-cloc-exclude-dhrs branch 4 times, most recently from a9445e4 to e18f4c1 Compare October 10, 2024 09:01

jaeschwa reviewed Oct 14, 2024

View reviewed changes

industry_lawyer/__manifest__.py Outdated Show resolved Hide resolved

non_profit_organization/__manifest__.py Outdated Show resolved Hide resolved

dhrs-odoo force-pushed the 18.0-cloc-exclude-dhrs branch from e18f4c1 to 12fcfa7 Compare October 14, 2024 08:39

dhrs-odoo force-pushed the 18.0-cloc-exclude-dhrs branch from 12fcfa7 to 1d02a9e Compare October 14, 2024 09:26

vava-odoo requested changes Nov 7, 2024

View reviewed changes

dhrs-odoo force-pushed the 18.0-cloc-exclude-dhrs branch from 1d02a9e to ff7662c Compare November 8, 2024 08:37

dhrs-odoo force-pushed the 18.0-cloc-exclude-dhrs branch from ff7662c to 82348da Compare November 19, 2024 12:01

dhrs-odoo force-pushed the 18.0-cloc-exclude-dhrs branch 15 times, most recently from 1d11756 to ea0cae1 Compare November 20, 2024 06:34

dhrs-odoo force-pushed the 18.0-cloc-exclude-dhrs branch from ea0cae1 to fdf2033 Compare November 20, 2024 09:18

vava-odoo requested changes Nov 20, 2024

View reviewed changes

agriculture_shop/demo/website_view.xml Show resolved Hide resolved

tests/test_generic/tests/test_industry_requirements.py Outdated Show resolved Hide resolved

dhrs-odoo force-pushed the 18.0-cloc-exclude-dhrs branch from 149a5a4 to deb1feb Compare November 21, 2024 11:03

vava-odoo requested changes Nov 21, 2024

View reviewed changes

dhrs-odoo added 5 commits November 25, 2024 10:04

[REF] .*: removed the model data and added cloc in manifest

83fc8e0

[REF] .*: new changes in the test case

b3484ab

[REF] .*: added new file

c5740c3

[REF] .*: made the file name consistent

815d3ad

reverting the files which were in data

34dc234

dhrs-odoo force-pushed the 18.0-cloc-exclude-dhrs branch from deb1feb to 34dc234 Compare November 25, 2024 05:14

[FIX]: made the minimum amount of diff

6ed6332

vava-odoo reviewed Nov 25, 2024

View reviewed changes

[FIX]: made the minimum amount of diff 2

000be75

dhrs-odoo force-pushed the 18.0-cloc-exclude-dhrs branch from 03649fd to 000be75 Compare November 25, 2024 12:14

vava-odoo changed the title ~~[REF] .*: removed the model data and added cloc in manifest~~ [IMP] *: replace ir.model.data by cloc_exclude entries in manifest Nov 25, 2024

vava-odoo approved these changes Nov 25, 2024

View reviewed changes

robodoo closed this in 5802a3a Nov 25, 2024

robodoo temporarily deployed to merge November 25, 2024 12:23 Inactive

fw-bot mentioned this pull request Nov 25, 2024

[FW][IMP] *: replace ir.model.data by cloc_exclude entries in manifest #307

Closed

vava-odoo deleted the 18.0-cloc-exclude-dhrs branch November 25, 2024 12:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] *: replace ir.model.data by cloc_exclude entries in manifest #267

[IMP] *: replace ir.model.data by cloc_exclude entries in manifest #267

dhrs-odoo commented Oct 9, 2024 •

edited by vava-odoo

Loading

vava-odoo left a comment

jaeschwa left a comment

jaeschwa left a comment

dhrs-odoo commented Oct 14, 2024

vava-odoo left a comment

robodoo commented Nov 19, 2024

robodoo commented Nov 19, 2024

dhrs-odoo commented Nov 20, 2024

vava-odoo left a comment

dhrs-odoo commented Nov 25, 2024

vava-odoo left a comment

vava-odoo left a comment

robodoo commented Nov 25, 2024

[IMP] *: replace ir.model.data by cloc_exclude entries in manifest #267

[IMP] *: replace ir.model.data by cloc_exclude entries in manifest #267

Conversation

dhrs-odoo commented Oct 9, 2024 • edited by vava-odoo Loading

vava-odoo left a comment

Choose a reason for hiding this comment

jaeschwa left a comment

Choose a reason for hiding this comment

jaeschwa left a comment

Choose a reason for hiding this comment

dhrs-odoo commented Oct 14, 2024

vava-odoo left a comment

Choose a reason for hiding this comment

robodoo commented Nov 19, 2024

robodoo commented Nov 19, 2024

dhrs-odoo commented Nov 20, 2024

vava-odoo left a comment

Choose a reason for hiding this comment

dhrs-odoo commented Nov 25, 2024

vava-odoo left a comment

Choose a reason for hiding this comment

vava-odoo left a comment

Choose a reason for hiding this comment

robodoo commented Nov 25, 2024

dhrs-odoo commented Oct 9, 2024 •

edited by vava-odoo

Loading