Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Quality: add spreadsheet check to QCP doc #11450

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

hojo-odoo
Copy link
Contributor

This PR updates the Quality control points doc to include the new Spreadsheet quality check type, which was added in version 18.0, as well as a note about needing to select a template when creating a new Worksheet/Spreadsheet QCP.

@robodoo
Copy link
Collaborator

robodoo commented Nov 23, 2024

Pull request status dashboard

@hojo-odoo hojo-odoo added the 2 label Nov 23, 2024
@C3POdoo C3POdoo requested a review from a team November 23, 2024 00:04
@hojo-odoo
Copy link
Contributor Author

Hey @Felicious,

This PR is ready for the first round of review!

Thanks,
John

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hojo-odoo ! Great job on this quick and concise update.

Fantastic job on this quick and concise update—it’s clear and well-structured!

I spotted a tiny field rename between versions and a very minor formatting tweak, but these are exactly the kind of details reviews are here to catch, so no worries at all. Overall, this is excellent work—great job! 🎉

@hojo-odoo hojo-odoo force-pushed the 18.0-quality-update-qcp-spreadsheet-check-hojo branch from a65b02e to 90dc242 Compare November 26, 2024 17:43
@hojo-odoo
Copy link
Contributor Author

Hey @ksc-odoo,

This PR is ready for final review.

Thanks,
John

Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @hojo-odoo -- nice job on this PR. Just finished my Final Review. Only a few comments that require your attention. Once you address those, and implement the modifications, feel free to tag this for Tech Review. 👍

@hojo-odoo hojo-odoo force-pushed the 18.0-quality-update-qcp-spreadsheet-check-hojo branch from 90dc242 to cc239c8 Compare November 26, 2024 23:33
@hojo-odoo hojo-odoo requested a review from a team November 26, 2024 23:57
@hojo-odoo
Copy link
Contributor Author

Hey @samueljlieber and @jero-odoo,

This PR is ready for tech review.

Thanks,
John

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants