-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] Quality: add spreadsheet check to QCP doc #11450
base: 18.0
Are you sure you want to change the base?
Conversation
Hey @Felicious, This PR is ready for the first round of review! Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hojo-odoo ! Great job on this quick and concise update.
Fantastic job on this quick and concise update—it’s clear and well-structured!
I spotted a tiny field rename between versions and a very minor formatting tweak, but these are exactly the kind of details reviews are here to catch, so no worries at all. Overall, this is excellent work—great job! 🎉
content/applications/inventory_and_mrp/quality/quality_management/quality_control_points.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_management/quality_control_points.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_management/quality_control_points.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_management/quality_control_points.rst
Show resolved
Hide resolved
a65b02e
to
90dc242
Compare
Hey @ksc-odoo, This PR is ready for final review. Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @hojo-odoo -- nice job on this PR. Just finished my Final Review. Only a few comments that require your attention. Once you address those, and implement the modifications, feel free to tag this for Tech Review. 👍
content/applications/inventory_and_mrp/quality/quality_management/quality_control_points.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_management/quality_control_points.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_management/quality_control_points.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_management/quality_control_points.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_management/quality_control_points.rst
Outdated
Show resolved
Hide resolved
90dc242
to
cc239c8
Compare
Hey @samueljlieber and @jero-odoo, This PR is ready for tech review. Thanks, |
This PR updates the Quality control points doc to include the new Spreadsheet quality check type, which was added in version 18.0, as well as a note about needing to select a template when creating a new Worksheet/Spreadsheet QCP.