Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Feature Branch] improve(design): Customize colorIcon token #654

Open
wants to merge 2 commits into
base: feature
Choose a base branch
from

Conversation

dengfuping
Copy link
Collaborator

@dengfuping dengfuping commented Jul 23, 2024

📦 Modified package

  • @oceanbase/design
  • @oceanbase/ui
  • @oceanbase/icons
  • @oceanbase/charts
  • @oceanbase/util
  • @oceanbase/codemod
  • Other (about what?)

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English -
🇨🇳 Chinese - 💄 colorIcon 默认颜色改为二级文本色 #5c6b8a,相较原先加深一级。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Tests is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Jul 23, 2024

@dengfuping dengfuping changed the title improve(design): colorIcon change to #5c6b8a as same as colorTextSecondary [Feature Branch] improve(design): colorIcon change to #5c6b8a as same as colorTextSecondary Jul 24, 2024
@dengfuping dengfuping changed the title [Feature Branch] improve(design): colorIcon change to #5c6b8a as same as colorTextSecondary [WIP] [Feature Branch] improve(design): Customize colorIcon token Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant