Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): add preflight before main commands run #260

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

antonbashmakov
Copy link

@antonbashmakov antonbashmakov commented Apr 5, 2024

PR-Codex overview

This PR updates preflight checks and licensing information.

Detailed summary

  • Added licensing information to preflight files
  • Implemented preflight checks in multiple commands
  • Added shell export in mvnw.js

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@antonbashmakov
Copy link
Author

@yegor256 tests failing on different platforms, does not seem to be problem in my code, is it an known issue?

@yegor256
Copy link
Member

yegor256 commented Apr 9, 2024

@antonbashmakov this is weird, but the build seems to be stable in the master branch.

@antonbashmakov
Copy link
Author

antonbashmakov commented Apr 9, 2024

@yegor256 seems like inspects foreign objects and prints a report is failing for windows the very same test is ok on Ubuntu. This code does not trigger function I wrote, so it should not be a problem. Can any one check tests on a windows machine?

@yegor256
Copy link
Member

yegor256 commented Apr 9, 2024

@antonbashmakov let's make a separate ticket about this, we will try to fix

@antonbashmakov
Copy link
Author

@yegor256 the error seems to be inconsistent, I pushed a trigger commit and now it is different result. Will any one take a look at the MR?

@antonbashmakov antonbashmakov marked this pull request as draft April 9, 2024 12:33
@antonbashmakov
Copy link
Author

@yegor256 interesting enough, the JSON generated by failing test is indeed broken :

{ "id": "org.eolang.ram", "discovered": "13", "xmir": "/home/runner/work/eoc/eoc/temp/test-foreign/simple/target/1-parse/org/eolang/ram.xmir", "optimized": "/home/runner/work/eoc/eoc/temp/test-foreign/simple/target/2-optimize/org/eolang/ram.xmir", "scope": "compile", "eo": "/home/runner/work/eoc/eoc/temp/test-foreign/simple/target/4-pull/org/eolang/ram.eo", "jar": "org.eolang:eo-runtime:0.35.8", "shaken": "/home/runner/work/eoc/eoc/temp/test-foreign/simple/target/3-shake/org/eolang/ram.xmir", "version": "0.35.8", "probed": "0", "hash": "d9c8741" } ]hash": "d9c8741" } ] Unexpected token h in JSON at position 18065

I tried to disable my changes but the error remains

@antonbashmakov
Copy link
Author

@yegor256 seems like all MR lately has the same problem. Like this one for instance

@antonbashmakov
Copy link
Author

@yegor256 ok, seems like version 0.35.8 of the plugin is behaving. It is some thing with 0.35.11 which makes it sad.

@antonbashmakov antonbashmakov force-pushed the abashmakov/prefligt-before-plugin branch from a403643 to 15ae11c Compare April 9, 2024 13:46
@yegor256
Copy link
Member

yegor256 commented Apr 9, 2024

@antonbashmakov let's make a separate issue and fix this problem over there

@antonbashmakov
Copy link
Author

antonbashmakov commented Apr 11, 2024

@yegor256 I think we should attack this problem in order to fix the pipelines. have you created a ticket for it?

UPD: I created it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants