Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Form)!: resolve async validation in yup & issue directly mutate state #2702

Merged
merged 3 commits into from
Nov 23, 2024
Merged

fix(Form)!: resolve async validation in yup & issue directly mutate state #2702

merged 3 commits into from
Nov 23, 2024

Conversation

rdjanuar
Copy link
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Follow up #2701

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@rdjanuar rdjanuar requested a review from romhml November 20, 2024 02:21
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 20, 2024 •
edited
Loading

Deploying ui3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 04b873e
Status: ✅  Deploy successful!
Preview URL: https://30c71cfb.ui-6q2.pages.dev
Branch Preview URL: https://v3-issue-2691.ui-6q2.pages.dev

View logs

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 20, 2024 •
edited
Loading 

pnpm add https://pkg.pr.new/@nuxt/ui@2702

commit: 04b873e

@benjamincanac benjamincanac added the v3 #1289 label Nov 20, 2024
@romhml romhml changed the title fix(Form): resolve async validation in yup & issue directly mutate state fix(Form)!: resolve async validation in yup & issue directly mutate state Nov 22, 2024
@benjamincanac benjamincanac merged commit c9806da into v3 Nov 23, 2024
3 checks passed
@benjamincanac benjamincanac deleted the v3-issue-2691 branch November 23, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romhml romhml romhml approved these changes

Assignees
No one assigned
Labels
v3 #1289
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rdjanuar @romhml @benjamincanac