nuxt-picture: allow parsing format as array #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Roe <[email protected]>
✅ Live Preview ready!
|
👷 Deploy request for nuxt-image pending review.Visit the deploys page to approve it
|
hartmut-co-uk
requested changes
Jun 26, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #886 +/- ##
==========================================
+ Coverage 89.15% 89.34% +0.19%
==========================================
Files 44 44
Lines 2914 2967 +53
Branches 323 328 +5
==========================================
+ Hits 2598 2651 +53
Misses 315 315
Partials 1 1
☔ View full report in Codecov by Sentry. |
danielroe
reviewed
Sep 13, 2023
| @@ -109,3 +118,47 @@ export const useBaseImage = (props: ExtractPropTypes<typeof baseImageProps>) => | |||
| modifiers | |||
| } | |||
| } | |||
|
|
|||
| export const useBasePicture = (props: ExtractPropTypes<typeof basePictureProps>) => { | |||
There was a problem hiding this comment.
For simplicity and reduced bundle size, do you think we can avoid splitting out useBasePicture and instead override the props directly in nuxt-img?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To better align the image format prop with the global setting for format, I now allow parsing an array as prop as well. Also minor tweaks to the docs and tests.