[nrf fromlist] drivers: serial: nrfx_uarte: Fix low power mode for interrupt driven API #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 20, 2024
nordic-krch
force-pushed
the
ncs/nrfx_uarte_fix_lp_int_driven
branch
from
a36d97e
to
88aa1dc
Compare
…terrupt driven API Low power mode for non-asynchronous API case is only available when RX is not used (RX pin is not defined). In that case TX starting function was using uarte_enable_locked() which tracks if UARTE is used by TX or RX and TXSTOPPED interrupt was disabling UARTE unconditionally. Because of that following attempt to TX start was assuming that UARTE is already enabled when it was disabled. Fixing it by using uarte_disable_locked function in TXSTOPPED handling. Code reordering was required to make uarte_disable_locked() available earlier. Upstream PR #: 81631 Signed-off-by: Krzysztof Chruściński <[email protected]>
kl-cruz
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for UARTE driver. Upstream PR: zephyrproject-rtos/zephyr#81631