Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes needed for SDP MSPI #2260

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jaz1-nordic
Copy link
Contributor

@jaz1-nordic jaz1-nordic commented Nov 13, 2024

Changes needed to implement SDP MSPI version:

  • configure SDP MSPI pins to switch their control to VPR core
  • make MSPI API test more generic and add nRF54L15 overlay file

Comment on lines 16 to 23
sdp_mspi: sdp_mspi@5004c000 {
mspi_device: mspi_device@0 {
status = "okay";
compatible = "zephyr,mspi-emul-device";
reg = <0x0>;
mspi-max-frequency = <48000000>;
};
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned offline, this redefinition is needed because those lines:
https://github.com/nrfconnect/sdk-nrf/pull/18893/files#diff-46fdf8d2608e604b87bd6b25d0cb3243ecc117f0d63f536def7c8e8532a09c41R87-R94
are applied only after this file.
I will look into how this could be solved, until now it would be nice to add a comment here about the issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've modified the driver a bit so that it's not necessary to use the address. Unfortunately, the order is still important.

tests/drivers/mspi/api/src/main.c Show resolved Hide resolved
tests/drivers/mspi/api/testcase.yaml Outdated Show resolved Hide resolved
drivers/pinctrl/pinctrl_nrf.c Outdated Show resolved Hide resolved
Comment on lines +373 to +375
dir = NRF_GPIO_PIN_DIR_OUTPUT;
input = NRF_GPIO_PIN_INPUT_CONNECT;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any expectations in VIO regarding pre-configuration by GPIO peripheral?
I'm wondering about the nrf_gpio_pin_write and nrf_gpio_cfg below.

@jaz1-nordic jaz1-nordic force-pushed the nrfx-6633_sdp_mspi branch 2 times, most recently from 89ff635 to d0b40cf Compare November 25, 2024 13:34
@jaz1-nordic jaz1-nordic changed the title [nrf noup] drivers: pinctrl: Add SDP MSPI pin configuration [nrf fromlist] Changes needed for SDP MSPI Nov 25, 2024
@jaz1-nordic jaz1-nordic force-pushed the nrfx-6633_sdp_mspi branch 2 times, most recently from 73a3080 to dc94f79 Compare November 25, 2024 14:05
@jaz1-nordic jaz1-nordic changed the title [nrf fromlist] Changes needed for SDP MSPI Changes needed for SDP MSPI Nov 25, 2024
@masz-nordic
Copy link
Contributor

Other 2 commits need noup

Add ifdefs to make MSPI API test more generic.

Upstream PR #: 81870

Signed-off-by: Jakub Zymelka <[email protected]>
Configure SDP MSPI pins to switch their control to VPR core

Signed-off-by: Jakub Zymelka <[email protected]>
Add nRF54l15 overlay file to be able to run SDP MSPI API test.

Signed-off-by: Jakub Zymelka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants