-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes needed for SDP MSPI #2260
base: main
Are you sure you want to change the base?
Conversation
4e5d7cd
to
6303428
Compare
6303428
to
5e9326e
Compare
sdp_mspi: sdp_mspi@5004c000 { | ||
mspi_device: mspi_device@0 { | ||
status = "okay"; | ||
compatible = "zephyr,mspi-emul-device"; | ||
reg = <0x0>; | ||
mspi-max-frequency = <48000000>; | ||
}; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned offline, this redefinition is needed because those lines:
https://github.com/nrfconnect/sdk-nrf/pull/18893/files#diff-46fdf8d2608e604b87bd6b25d0cb3243ecc117f0d63f536def7c8e8532a09c41R87-R94
are applied only after this file.
I will look into how this could be solved, until now it would be nice to add a comment here about the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've modified the driver a bit so that it's not necessary to use the address. Unfortunately, the order is still important.
dir = NRF_GPIO_PIN_DIR_OUTPUT; | ||
input = NRF_GPIO_PIN_INPUT_CONNECT; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any expectations in VIO regarding pre-configuration by GPIO peripheral?
I'm wondering about the nrf_gpio_pin_write
and nrf_gpio_cfg
below.
89ff635
to
d0b40cf
Compare
73a3080
to
dc94f79
Compare
Other 2 commits need |
dc94f79
to
0dd7466
Compare
Add ifdefs to make MSPI API test more generic. Upstream PR #: 81870 Signed-off-by: Jakub Zymelka <[email protected]>
Configure SDP MSPI pins to switch their control to VPR core Signed-off-by: Jakub Zymelka <[email protected]>
Add nRF54l15 overlay file to be able to run SDP MSPI API test. Signed-off-by: Jakub Zymelka <[email protected]>
0dd7466
to
f345131
Compare
Changes needed to implement SDP MSPI version: