Skip to content

Nrfx 5244 align i2 s tests to tdm #7712

Nrfx 5244 align i2 s tests to tdm

Nrfx 5244 align i2 s tests to tdm #7712

Triggered via pull request November 28, 2024 15:09
Status Failure
Total duration 2m 52s
Artifacts 1

compliance.yml

on: pull_request
Run compliance checks on patch series (PR)
2m 44s
Run compliance checks on patch series (PR)
Fit to window
Zoom out
Zoom in

Annotations

13 errors, 11 warnings, and 4 notices
Run compliance checks on patch series (PR)
Process completed with exit code 1.
CODE_INDENT: tests/drivers/i2s/i2s_api/src/common.c#L20
tests/drivers/i2s/i2s_api/src/common.c:20 code indent should use tabs where possible
CODE_INDENT: tests/drivers/i2s/i2s_api/src/common.c#L21
tests/drivers/i2s/i2s_api/src/common.c:21 code indent should use tabs where possible
CODE_INDENT: tests/drivers/i2s/i2s_api/src/common.c#L22
tests/drivers/i2s/i2s_api/src/common.c:22 code indent should use tabs where possible
CODE_INDENT: tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c#L69
tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c:69 code indent should use tabs where possible
CODE_INDENT: tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c#L70
tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c:70 code indent should use tabs where possible
CODE_INDENT: tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c#L71
tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c:71 code indent should use tabs where possible
Run compliance checks on patch series (PR)
Process completed with exit code 5.
Run compliance checks on patch series (PR): Gitlint.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details Commit c3b08682ef: 1: UC6 Commit message body is empty, should at least have 1 line(s).
Run compliance checks on patch series (PR): Checkpatch.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details. LEADING_SPACE: please, no spaces at the start of a line File:tests/drivers/i2s/i2s_api/boards/nrf54h20dk_nrf54h20_cpuapp.overlay Line:36 LEADING_SPACE: please, no spaces at the start of a line File:tests/drivers/i2s/i2s_api/src/common.c Line:19 CODE_INDENT: code indent should use tabs where possible File:tests/drivers/i2s/i2s_api/src/common.c Line:20 LEADING_SPACE: please, no spaces at the start of a line File:tests/drivers/i2s/i2s_api/src/common.c Line:20 CODE_INDENT: code indent should use tabs where possible File:tests/drivers/i2s/i2s_api/src/common.c Line:21 LEADING_SPACE: please, no spaces at the start of a line File:tests/drivers/i2s/i2s_api/src/common.c Line:21 CODE_INDENT: code indent should use tabs where possible File:tests/drivers/i2s/i2s_api/src/common.c Line:22 LEADING_SPACE: please, no spaces at the start of a line File:tests/drivers/i2s/i2s_api/src/common.c Line:22 LONG_LINE: line length of 101 exceeds 100 columns File:tests/drivers/i2s/i2s_api/src/common.c Line:27 LEADING_SPACE: please, no spaces at the start of a line File:tests/drivers/i2s/i2s_speed/boards/nrf54h20dk_nrf54h20_cpuapp.overlay Line:36 LEADING_SPACE: please, no spaces at the start of a line File:tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c Line:68 CODE_INDENT: code indent should use tabs where possible File:tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c Line:69 LEADING_SPACE: please, no spaces at the start of a line File:tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c Line:69 CODE_INDENT: code indent should use tabs where possible File:tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c Line:70 LEADING_SPACE: please, no spaces at the start of a line File:tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c Line:70 CODE_INDENT: code indent should use tabs where possible File:tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c Line:71 LEADING_SPACE: please, no spaces at the start of a line File:tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c Line:71
Run compliance checks on patch series (PR): GitDiffCheck.txt#L1
Git conflict markers and whitespace errors are not allowed in added changes c3b08682eff18cb75fcbd3a2884a383846cf3c49: tests/drivers/i2s/i2s_api/boards/nrf54h20dk_nrf54h20_cpuapp.overlay:38: new blank line at EOF. c3b08682eff18cb75fcbd3a2884a383846cf3c49: tests/drivers/i2s/i2s_speed/boards/nrf54h20dk_nrf54h20_cpuapp.overlay:38: new blank line at EOF.
Run compliance checks on patch series (PR): Nits.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details. Please remove blank lines at end of 'tests/drivers/i2s/i2s_api/boards/nrf54h20dk_nrf54h20_cpuapp.overlay' Please remove blank lines at end of 'tests/drivers/i2s/i2s_speed/boards/nrf54h20dk_nrf54h20_cpuapp.overlay'
Run compliance checks on patch series (PR)
Process completed with exit code 1.
LEADING_SPACE: tests/drivers/i2s/i2s_api/boards/nrf54h20dk_nrf54h20_cpuapp.overlay#L36
tests/drivers/i2s/i2s_api/boards/nrf54h20dk_nrf54h20_cpuapp.overlay:36 please, no spaces at the start of a line
LEADING_SPACE: tests/drivers/i2s/i2s_api/src/common.c#L19
tests/drivers/i2s/i2s_api/src/common.c:19 please, no spaces at the start of a line
LEADING_SPACE: tests/drivers/i2s/i2s_api/src/common.c#L20
tests/drivers/i2s/i2s_api/src/common.c:20 please, no spaces at the start of a line
LEADING_SPACE: tests/drivers/i2s/i2s_api/src/common.c#L21
tests/drivers/i2s/i2s_api/src/common.c:21 please, no spaces at the start of a line
LEADING_SPACE: tests/drivers/i2s/i2s_api/src/common.c#L22
tests/drivers/i2s/i2s_api/src/common.c:22 please, no spaces at the start of a line
LONG_LINE: tests/drivers/i2s/i2s_api/src/common.c#L27
tests/drivers/i2s/i2s_api/src/common.c:27 line length of 101 exceeds 100 columns
LEADING_SPACE: tests/drivers/i2s/i2s_speed/boards/nrf54h20dk_nrf54h20_cpuapp.overlay#L36
tests/drivers/i2s/i2s_speed/boards/nrf54h20dk_nrf54h20_cpuapp.overlay:36 please, no spaces at the start of a line
LEADING_SPACE: tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c#L68
tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c:68 please, no spaces at the start of a line
LEADING_SPACE: tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c#L69
tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c:69 please, no spaces at the start of a line
LEADING_SPACE: tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c#L70
tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c:70 please, no spaces at the start of a line
Run compliance checks on patch series (PR): ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details. You may want to run clang-format on this change: - IF_ENABLED(CONFIG_CLOCK_CONTROL_NRF, \ - (init_clock_manager(dev);)) \ + IF_ENABLED(CONFIG_CLOCK_CONTROL_NRF, (init_clock_manager(dev);)) \ File:drivers/i2s/i2s_nrfx_tdm.c Line:1034 You may want to run clang-format on this change: -#define NRF_FUN_TDM_SCK_M 48U +#define NRF_FUN_TDM_SCK_M 48U /** TDM SCK in slave mode */ -#define NRF_FUN_TDM_SCK_S 49U +#define NRF_FUN_TDM_SCK_S 49U /** TDM LRCK in master mode */ #define NRF_FUN_TDM_FSYNC_M 50U /** TDM LRCK in slave mode */ #define NRF_FUN_TDM_FSYNC_S 51U /** TDM SDIN */ -#define NRF_FUN_TDM_SDIN 52U +#define NRF_FUN_TDM_SDIN 52U /** TDM SDOUT */ -#define NRF_FUN_TDM_SDOUT 53U +#define NRF_FUN_TDM_SDOUT 53U /** TDM MCK */ -#define NRF_FUN_TDM_MCK 54U +#define NRF_FUN_TDM_MCK 54U File:include/zephyr/dt-bindings/pinctrl/nrf-pinctrl.h Line:179 You may want to run clang-format on this change: -#define TDM(idx) DT_NODELABEL(tdm##idx) -#define TDM_PROP(idx, prop) DT_PROP(TDM(idx), prop) -#define TDM_HAS_PROP(idx, prop) DT_NODE_HAS_PROP(TDM(idx), prop) - - -#define TDM_MEMORY_SECTION(idx) \ - COND_CODE_1(TDM_HAS_PROP(idx, memory_regions), \ - (__attribute__((__section__(LINKER_DT_NODE_REGION_NAME( \ - DT_PHANDLE(TDM(idx), memory_regions)))))), \ - ()) +#define TDM(idx) DT_NODELABEL(tdm##idx) +#define TDM_PROP(idx, prop) DT_PROP(TDM(idx), prop) +#define TDM_HAS_PROP(idx, prop) DT_NODE_HAS_PROP(TDM(idx), prop) + +#define TDM_MEMORY_SECTION(idx) \ + COND_CODE_1(TDM_HAS_PROP(idx, memory_regions), \ + (__attribute__((__section__( \ + LINKER_DT_NODE_REGION_NAME(DT_PHANDLE(TDM(idx), memory_regions)))))), \ + ()) #define BUFFER_MEM_REGION __attribute__((__section__("cpuapp_dma_region"))) -char __aligned(WB_UP(32)) - _k_mem_slab_buf_rx_mem_slab[(NUM_RX_BLOCKS + 2) * WB_UP(BLOCK_SIZE)] TDM_MEMORY_SECTION(130); -STRUCT_SECTION_ITERABLE(k_mem_slab, rx_mem_slab) = - Z_MEM_SLAB_INITIALIZER(rx_mem_slab, _k_mem_slab_buf_rx_mem_slab, - WB_UP(BLOCK_SIZE), NUM_RX_BLOCKS + 2); - -char __aligned(WB_UP(32)) - _k_mem_slab_buf_tx_mem_slab[(NUM_TX_BLOCKS) * WB_UP(BLOCK_SIZE)] TDM_MEMORY_SECTION(130); -STRUCT_SECTION_ITERABLE(k_mem_slab, tx_mem_slab) = - Z_MEM_SLAB_INITIALIZER(tx_mem_slab, _k_mem_slab_buf_tx_mem_slab, - WB_UP(BLOCK_SIZE), NUM_TX_BLOCKS); +char __aligned(WB_UP(32)) +_k_mem_slab_buf_rx_mem_slab[(NUM_RX_BLOCKS + 2) * WB_UP(BLOCK_SIZE)] TDM_MEMORY_SECTION(130); +STRUCT_SECTION_ITERABLE(k_mem_slab, + rx_mem_slab) = Z_MEM_SLAB_INITIALIZER(rx_mem_slab, + _k_mem_slab_buf_rx_mem_slab, + WB_UP(BLOCK_SIZE), NUM_RX_BLOCKS + 2); + +char __aligned(WB_UP(32)) +_k_mem_slab_buf_tx_mem_slab[(NUM_TX_BLOCKS)*WB_UP(BLOCK_SIZE)] TDM_MEMORY_SECTION(130); +STRUCT_SECTION_ITERABLE(k_mem_slab, + tx_mem_slab) = Z_MEM_SLAB_INITIALIZER(tx_mem_slab, + _k_mem_slab_buf_tx_mem_slab, + WB_UP(BLOCK_SIZE), NUM_TX_BLOCKS); File:tests/drivers/i2s/i2s_api/src/common.c Line:37 You may want to run clang-format on this change: -#define TDM(idx) DT_NODELABEL(tdm##idx) -#define TDM_PROP(idx, prop) DT_PROP(TDM(idx), prop) -#define TDM_HAS_PROP(idx, prop) DT_NODE_HAS_PROP(TDM(idx), prop) - - -#define TDM_MEMORY_SECTION(idx) \ - COND_CODE_1(TDM_HAS_PROP(idx, memory_regions), \ - (__attribute__((__section__(LINKER_DT_NODE_REGION_NAME( \ - DT_PHANDLE(TDM(idx), memory_regions)))))),
You may want to run clang-format on this change: drivers/i2s/i2s_nrfx_tdm.c#L1034
drivers/i2s/i2s_nrfx_tdm.c:1034 - IF_ENABLED(CONFIG_CLOCK_CONTROL_NRF, \ - (init_clock_manager(dev);)) \ + IF_ENABLED(CONFIG_CLOCK_CONTROL_NRF, (init_clock_manager(dev);)) \
You may want to run clang-format on this change: include/zephyr/dt-bindings/pinctrl/nrf-pinctrl.h#L179
include/zephyr/dt-bindings/pinctrl/nrf-pinctrl.h:179 -#define NRF_FUN_TDM_SCK_M 48U +#define NRF_FUN_TDM_SCK_M 48U /** TDM SCK in slave mode */ -#define NRF_FUN_TDM_SCK_S 49U +#define NRF_FUN_TDM_SCK_S 49U /** TDM LRCK in master mode */ #define NRF_FUN_TDM_FSYNC_M 50U /** TDM LRCK in slave mode */ #define NRF_FUN_TDM_FSYNC_S 51U /** TDM SDIN */ -#define NRF_FUN_TDM_SDIN 52U +#define NRF_FUN_TDM_SDIN 52U /** TDM SDOUT */ -#define NRF_FUN_TDM_SDOUT 53U +#define NRF_FUN_TDM_SDOUT 53U /** TDM MCK */ -#define NRF_FUN_TDM_MCK 54U +#define NRF_FUN_TDM_MCK 54U
You may want to run clang-format on this change: tests/drivers/i2s/i2s_api/src/common.c#L37
tests/drivers/i2s/i2s_api/src/common.c:37 -#define TDM(idx) DT_NODELABEL(tdm##idx) -#define TDM_PROP(idx, prop) DT_PROP(TDM(idx), prop) -#define TDM_HAS_PROP(idx, prop) DT_NODE_HAS_PROP(TDM(idx), prop) - - -#define TDM_MEMORY_SECTION(idx) \ - COND_CODE_1(TDM_HAS_PROP(idx, memory_regions), \ - (__attribute__((__section__(LINKER_DT_NODE_REGION_NAME( \ - DT_PHANDLE(TDM(idx), memory_regions)))))), \ - ()) +#define TDM(idx) DT_NODELABEL(tdm##idx) +#define TDM_PROP(idx, prop) DT_PROP(TDM(idx), prop) +#define TDM_HAS_PROP(idx, prop) DT_NODE_HAS_PROP(TDM(idx), prop) + +#define TDM_MEMORY_SECTION(idx) \ + COND_CODE_1(TDM_HAS_PROP(idx, memory_regions), \ + (__attribute__((__section__( \ + LINKER_DT_NODE_REGION_NAME(DT_PHANDLE(TDM(idx), memory_regions)))))), \ + ()) #define BUFFER_MEM_REGION __attribute__((__section__("cpuapp_dma_region"))) -char __aligned(WB_UP(32)) - _k_mem_slab_buf_rx_mem_slab[(NUM_RX_BLOCKS + 2) * WB_UP(BLOCK_SIZE)] TDM_MEMORY_SECTION(130); -STRUCT_SECTION_ITERABLE(k_mem_slab, rx_mem_slab) = - Z_MEM_SLAB_INITIALIZER(rx_mem_slab, _k_mem_slab_buf_rx_mem_slab, - WB_UP(BLOCK_SIZE), NUM_RX_BLOCKS + 2); - -char __aligned(WB_UP(32)) - _k_mem_slab_buf_tx_mem_slab[(NUM_TX_BLOCKS) * WB_UP(BLOCK_SIZE)] TDM_MEMORY_SECTION(130); -STRUCT_SECTION_ITERABLE(k_mem_slab, tx_mem_slab) = - Z_MEM_SLAB_INITIALIZER(tx_mem_slab, _k_mem_slab_buf_tx_mem_slab, - WB_UP(BLOCK_SIZE), NUM_TX_BLOCKS); +char __aligned(WB_UP(32)) +_k_mem_slab_buf_rx_mem_slab[(NUM_RX_BLOCKS + 2) * WB_UP(BLOCK_SIZE)] TDM_MEMORY_SECTION(130); +STRUCT_SECTION_ITERABLE(k_mem_slab, + rx_mem_slab) = Z_MEM_SLAB_INITIALIZER(rx_mem_slab, + _k_mem_slab_buf_rx_mem_slab, + WB_UP(BLOCK_SIZE), NUM_RX_BLOCKS + 2); + +char __aligned(WB_UP(32)) +_k_mem_slab_buf_tx_mem_slab[(NUM_TX_BLOCKS)*WB_UP(BLOCK_SIZE)] TDM_MEMORY_SECTION(130); +STRUCT_SECTION_ITERABLE(k_mem_slab, + tx_mem_slab) = Z_MEM_SLAB_INITIALIZER(tx_mem_slab, + _k_mem_slab_buf_tx_mem_slab, + WB_UP(BLOCK_SIZE), NUM_TX_BLOCKS);
You may want to run clang-format on this change: tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c#L83
tests/drivers/i2s/i2s_speed/src/test_i2s_speed.c:83 -#define TDM(idx) DT_NODELABEL(tdm##idx) -#define TDM_PROP(idx, prop) DT_PROP(TDM(idx), prop) -#define TDM_HAS_PROP(idx, prop) DT_NODE_HAS_PROP(TDM(idx), prop) - - -#define TDM_MEMORY_SECTION(idx) \ - COND_CODE_1(TDM_HAS_PROP(idx, memory_regions), \ - (__attribute__((__section__(LINKER_DT_NODE_REGION_NAME( \ - DT_PHANDLE(TDM(idx), memory_regions)))))), \ - ()) +#define TDM(idx) DT_NODELABEL(tdm##idx) +#define TDM_PROP(idx, prop) DT_PROP(TDM(idx), prop) +#define TDM_HAS_PROP(idx, prop) DT_NODE_HAS_PROP(TDM(idx), prop) + +#define TDM_MEMORY_SECTION(idx) \ + COND_CODE_1(TDM_HAS_PROP(idx, memory_regions), \ + (__attribute__((__section__( \ + LINKER_DT_NODE_REGION_NAME(DT_PHANDLE(TDM(idx), memory_regions)))))), \ + ()) #define BUFFER_MEM_REGION __attribute__((__section__("cpuapp_dma_region"))) char MEM_SLAB_CACHE_ATTR __aligned(WB_UP(32)) - _k_mem_slab_buf_rx_0_mem_slab[(NUM_BLOCKS + 2) * WB_UP(BLOCK_SIZE)] TDM_MEMORY_SECTION(130); +_k_mem_slab_buf_rx_0_mem_slab[(NUM_BLOCKS + 2) * WB_UP(BLOCK_SIZE)] TDM_MEMORY_SECTION(130); STRUCT_SECTION_ITERABLE(k_mem_slab, rx_0_mem_slab) = Z_MEM_SLAB_INITIALIZER(rx_0_mem_slab, _k_mem_slab_buf_rx_0_mem_slab, WB_UP(BLOCK_SIZE), NUM_BLOCKS + 2); char MEM_SLAB_CACHE_ATTR __aligned(WB_UP(32)) - _k_mem_slab_buf_tx_0_mem_slab[(NUM_BLOCKS) * WB_UP(BLOCK_SIZE)] TDM_MEMORY_SECTION(130); +_k_mem_slab_buf_tx_0_mem_slab[(NUM_BLOCKS)*WB_UP(BLOCK_SIZE)] TDM_MEMORY_SECTION(130);

Artifacts

Produced during runtime
Name Size
compliance.xml
2 KB