-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nrf_rpc: Add command to obtain version of remote. #19011
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 1cf2330a882dca5849351a0e576714e567a48117 more detailssdk-nrf:
Github labels
List of changed files detected by CI (30)
Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
4bf2e44
to
24aa195
Compare
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
76c071d
to
1f98ad5
Compare
1f98ad5
to
b9f993a
Compare
b9f993a
to
96dbd9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't a changelog is required?
6160219
to
b63cf38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final nits but lgtm overall.
b63cf38
to
6f43587
Compare
Remember also the changelog entry. |
6f43587
to
4d12e8a
Compare
4d12e8a
to
8096849
Compare
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
8096849
to
fa19732
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit. for future note
Commit adds command to pbtain the remote ncs commit sha version. Signed-off-by: Przemyslaw Bida <[email protected]>
fa19732
to
1cf2330
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion - when I see dev_info I would rather expect more information about the device itself. This should be rather ncs_info. What about release minor and major? Sha itself would not give us a lot of feedback.
Commit adds command to pbtain the remote ncs commit sha version.