Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf_rpc: Add command to obtain version of remote. #19011

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

canisLupus1313
Copy link
Contributor

Commit adds command to pbtain the remote ncs commit sha version.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 21, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 21, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 19

Inputs:

Sources:

sdk-nrf: PR head: 1cf2330a882dca5849351a0e576714e567a48117

more details

sdk-nrf:

PR head: 1cf2330a882dca5849351a0e576714e567a48117
merge base: af6d9851d03b8bb5471fe5f2cc107b9876dd083b
target head (main): e2cfdfd0f4c8b30e89463b7f421b4e27f2f1f35e
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (30)
CODEOWNERS
doc
│  ├── nrf
│  │  ├── libraries
│  │  │  ├── nrf_rpc
│  │  │  │  │ nrf_rpc_dev_info.rst
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
include
│  ├── nrf_rpc
│  │  │ nrf_rpc_dev_info.h
samples
│  ├── nrf_rpc
│  │  ├── protocols_serialization
│  │  │  ├── client
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── prj.conf
│  │  │  │  ├── src
│  │  │  │  │  │ dev_info_shell.c
│  │  │  ├── server
│  │  │  │  │ prj.conf
subsys
│  ├── nrf_rpc
│  │  ├── CMakeLists.txt
│  │  ├── Kconfig
│  │  ├── dev_info
│  │  │  ├── CMakeLists.txt
│  │  │  ├── Kconfig
│  │  │  ├── client
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  │ dev_info_client.c
│  │  │  ├── common
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── dev_info_rpc.c
│  │  │  │  │ dev_info_rpc_ids.h
│  │  │  ├── server
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  │ dev_info_server.c
│  │  ├── include
│  │  │  │ nrf_rpc_os.h
tests
│  ├── subsys
│  │  ├── nrf_rpc
│  │  │  ├── dev_info
│  │  │  │  ├── client
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── prj.conf
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ dev_info_suite.c
│  │  │  │  │  │ testcase.yaml
│  │  │  │  ├── common
│  │  │  │  │  ├── nrf_rpc_single_thread.c
│  │  │  │  │  │ test_rpc_env.h
│  │  │  │  ├── server
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── prj.conf
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ dev_info_suite.c
│  │  │  │  │  │ testcase.yaml

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 18
  • ✅ Integration tests
    • ✅ test_ble_nrf_config - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-rpc - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-dfu - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ps - Skipped: Job was skipped as it succeeded in a previous run
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 21, 2024
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@canisLupus1313 canisLupus1313 marked this pull request as ready for review November 22, 2024 07:17
@canisLupus1313 canisLupus1313 requested review from a team as code owners November 22, 2024 07:17
subsys/nrf_rpc/include/nrf_rpc_utils.h Outdated Show resolved Hide resolved
subsys/nrf_rpc/utils/Kconfig Outdated Show resolved Hide resolved
subsys/nrf_rpc/utils/client/utils_client.c Outdated Show resolved Hide resolved
subsys/nrf_rpc/utils/client/utils_client.c Outdated Show resolved Hide resolved
subsys/nrf_rpc/utils/client/utils_client.c Outdated Show resolved Hide resolved
subsys/nrf_rpc/utils/client/utils_client.c Outdated Show resolved Hide resolved
tests/subsys/nrf_rpc/utils/client/prj.conf Outdated Show resolved Hide resolved
tests/subsys/nrf_rpc/utils/client/src/utils_suite.c Outdated Show resolved Hide resolved
tests/subsys/nrf_rpc/utils/server/prj.conf Outdated Show resolved Hide resolved
tests/subsys/nrf_rpc/utils/server/src/utils_suite.c Outdated Show resolved Hide resolved
@canisLupus1313 canisLupus1313 force-pushed the vendor_version_utility branch 6 times, most recently from 76c071d to 1f98ad5 Compare December 3, 2024 09:25
@canisLupus1313 canisLupus1313 requested a review from a team as a code owner December 3, 2024 09:38
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Dec 3, 2024
subsys/nrf_rpc/include/nrf_rpc_utils.h Outdated Show resolved Hide resolved
subsys/nrf_rpc/include/nrf_rpc_utils.h Outdated Show resolved Hide resolved
subsys/nrf_rpc/include/nrf_rpc_utils.h Outdated Show resolved Hide resolved
doc/nrf/libraries/nrf_rpc/nrf_rpc_utils.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@divipillai divipillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't a changelog is required?

doc/nrf/libraries/nrf_rpc/nrf_rpc_utils.rst Outdated Show resolved Hide resolved
@canisLupus1313 canisLupus1313 force-pushed the vendor_version_utility branch 3 times, most recently from 6160219 to b63cf38 Compare December 3, 2024 12:32
@canisLupus1313 canisLupus1313 requested a review from a team as a code owner December 3, 2024 12:32
Copy link
Contributor

@Damian-Nordic Damian-Nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final nits but lgtm overall.

doc/nrf/libraries/nrf_rpc/nrf_rpc_dev_info.rst Outdated Show resolved Hide resolved
subsys/nrf_rpc/dev_info/common/dev_info_rpc.c Outdated Show resolved Hide resolved
subsys/nrf_rpc/dev_info/common/dev_info_rpc_ids.h Outdated Show resolved Hide resolved
@peknis
Copy link
Contributor

peknis commented Dec 3, 2024

Remember also the changelog entry.

Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit. for future note

subsys/nrf_rpc/dev_info/Kconfig Outdated Show resolved Hide resolved
subsys/nrf_rpc/dev_info/Kconfig Show resolved Hide resolved
Commit adds command to pbtain the remote ncs commit sha version.

Signed-off-by: Przemyslaw Bida <[email protected]>
Copy link
Contributor

@rakons rakons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion - when I see dev_info I would rather expect more information about the device itself. This should be rather ncs_info. What about release minor and major? Sha itself would not give us a lot of feedback.

@rlubos rlubos merged commit 93c10ee into nrfconnect:main Dec 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.