Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RPM build for macs #8270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tangledbytes
Copy link
Member

Explain the changes

This PR attempts to fix RPM build process and make them more portable by relying on docker cp instead of volume mounts.

Testing Instructions:

Run make rpm and check if you can get the RPM inside build/rpm directory once done.

  • Doc added/updated
  • Tests added

Signed-off-by: Utkarsh Srivastava <[email protected]>
@tangledbytes
Copy link
Member Author

@romayalon @naveenpaul1 @shirady please pull this branch and see if this resolves the make rpm issue for you.

@romayalon
Copy link
Contributor

Hey @tangledbytes
I tried it and looks like there is still an issue -

...
mkdir -p /build/rpm && docker cp noobaa-rpm-build-env:/export/. /build/rpm/
mkdir: /build: Read-only file system
make: *** [rpm] Error 1
noobaa-core % ls /build
ls: /build: No such file or directory
noobaa-core % pwd

Copy link

This PR had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed.

@github-actions github-actions bot added the Stale label Nov 11, 2024
@romayalon romayalon removed the Stale label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants