-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nodejs fixes #242
base: main
Are you sure you want to change the base?
Nodejs fixes #242
Conversation
Note that the test failed due to memory issues while building prettier, which are unrelated to this PR |
and the prettier build is failing because it has a Would it not be better to require main packages to specify |
config = ts.parseConfigFileTextToJson(data); | ||
|
||
// https://www.typescriptlang.org/tsconfig#preserveSymlinks | ||
config.compilerOptions.preserveSymlinks = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic is redundant with
${pkgs.jq}/bin/jq ".compilerOptions.preserveSymlinks = true" tsconfig.json \ |
@@ -14,7 +14,7 @@ | |||
|
|||
changed = False | |||
|
|||
# fail if platform incompatible | |||
# fail if platform incompatible - should not happen due to filters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which filters do you mean?
We should either increase the
What do you mean by standard npm scripts? |
no need for package-json.bak, just put the original data aside in the JSON.
No description provided.