test(netlify-edge): add tests #2897
Conversation
| // netlify-edge intentionally ignores prerendered routes | ||
| it.skipIf(ctx.preset === "netlify-edge")( | ||
| "prerendered API routes work", |
There was a problem hiding this comment.
@pi0 I believe you didn't like this in the original PR. Let me know if you have any other ideas 🤷🏼.
There was a problem hiding this comment.
prerendered routes are basically static assets. Maybe worth to implement small stub in request handler that emulates netlify edge behavior? (otherwise current hotfix if allows to move it forward faster is good enough IMO -- we can do later)
| }; | ||
| return async ({ url: rawRelativeUrl, headers, method, body }) => { | ||
| // creating new URL object to parse query easier | ||
| const url = new URL(`https://example.com${rawRelativeUrl}`); |
There was a problem hiding this comment.
Can we use newURL(rawRelativeUrl, headers['host'])? (right now we don't have host tests I guess but it might fail later and need the right fix.
| // netlify-edge intentionally ignores prerendered routes | ||
| it.skipIf(ctx.preset === "netlify-edge")( | ||
| "prerendered API routes work", |
There was a problem hiding this comment.
prerendered routes are basically static assets. Maybe worth to implement small stub in request handler that emulates netlify edge behavior? (otherwise current hotfix if allows to move it forward faster is good enough IMO -- we can do later)
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
🔗 Linked issue
N/A
❓ Type of change
📚 Description
The
netlify-edgepreset has no tests. This adds tests.Previously added in #2822 but cut out before merging.
📝 Checklist