-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Graal js language to support Java 22 #24
Conversation
specifically with truffle api library dropping sun.misc.Unsafe which is no longer present in Java 22. See also * oracle/graal#7510 * https://bugs.openjdk.org/browse/JDK-8316160
With the latest graal truffle we get support for Java 22, but we need at least Java 17, CI is on Java 11 and throws
|
Weirdly enough I get this error when I run tests, but my colleagues don't with the same version of JDK (temurin11). But more importantly, why does this library even depend on graalvm? Is that necessary for just using it for Clojure? |
Yes, it is. Strictly speaking, we're not depending on GraalVM, but we're using the graal polyglot library to call the markdown-it tokenizer on the JVM (GraalVM or any else), this guarantees the same behaviour on both clj/s sides. We're probably dropping this approach in #25. |
Ah nice good to know it might not be needed anymore soon, thanks |
Obsolete since #28. |
Specifically with truffle api library dropping
sun.misc.Unsafe
which is no longer present in Java 22:Closes #23.
🚧 This will probably not be merged, as we'd lose support of Java 11. We're trying to drop Graal polyglot (#25) for the clj side of things.