NETOBSERV-1913 skip <br> when bundle

[jpinsonneau]

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jpinsonneau]

@jotak I feel that would be good enough as it's running only when bundle target is called.
Let me know if there is any concern here

[jotak]

the problem is that the downstream doc is generated from the final CRD as well. So this would break asciidoc formatting, see the generated asciidoc from your PR:

[jpinsonneau]

oh ok! In that case we need to have two crds generated if we want to go that way 🙃

• one for the doc
• one for the bundle

We could have two targets in the Makefile or reuse CLEAN_BUILD param but it means the downstream pipeline will have to generate these unless we keep two version of CRDs upstream 🤔

WDYT ?

[jotak]

Like I said in jira is it really worth it to change the build process for that, since we want to move away from the OLM form anyway, and have our own form? I don't think we should spend much time here ....

[jpinsonneau]

Even if you move away from the creation form, the YAML editor still display those descriptions.
Plus, most of the time, the editing is done outside of forms. That's why I wanted to see if we can find a quick solution here

[openshift-ci]

@jpinsonneau: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-operator	aedaf7e	link	false	/test e2e-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.