Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1974: Refactor network events to return list of maps instead of strings #458

Merged

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Nov 13, 2024

Description

Network events was orignally decode as string with this recent ovnk lib it will come as struct and the agent need to generate list of configmaps with those events
this effort to allow generating metrics with network events

Dependencies

ovn-kubernetes/ovn-kubernetes#4818

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.65%. Comparing base (294ae3f) to head (8a66665).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
+ Coverage   29.56%   29.65%   +0.08%     
==========================================
  Files          50       50              
  Lines        4867     4863       -4     
==========================================
+ Hits         1439     1442       +3     
+ Misses       3322     3316       -6     
+ Partials      106      105       -1     
Flag Coverage Δ
unittests 29.65% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/decode/decode_protobuf.go 29.97% <100.00%> (+1.23%) ⬆️
pkg/model/record.go 68.88% <100.00%> (ø)

pkg/pbflow/proto.go Outdated Show resolved Hide resolved
pkg/pbflow/proto.go Outdated Show resolved Hide resolved
@msherif1234 msherif1234 marked this pull request as ready for review November 14, 2024 11:46
@msherif1234 msherif1234 changed the title WIP: refactor network events to return list of struct instead of strings Refactor network events to return list of struct instead of strings Nov 14, 2024
@msherif1234 msherif1234 changed the title Refactor network events to return list of struct instead of strings Refactor network events to return list of maps instead of strings Nov 14, 2024
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 14, 2024
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:2f889b8

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=2f889b8 make set-agent-image

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 14, 2024
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 14, 2024
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:18481c0

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=18481c0 make set-agent-image

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 14, 2024
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 14, 2024
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:2c10edc

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=2c10edc make set-agent-image

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 14, 2024
Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Nov 20, 2024
@openshift-ci openshift-ci bot removed the lgtm label Nov 20, 2024
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 20, 2024
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 20, 2024
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:d92e038

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=d92e038 make set-agent-image

@jotak
Copy link
Member

jotak commented Nov 21, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 21, 2024
@openshift-ci openshift-ci bot removed the lgtm label Nov 26, 2024
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 26, 2024
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 26, 2024
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:d61148e

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=d61148e make set-agent-image

@jotak
Copy link
Member

jotak commented Nov 26, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 26, 2024
@msherif1234
Copy link
Contributor Author

/approve

Copy link

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msherif1234 msherif1234 changed the title Refactor network events to return list of maps instead of strings NETOBSERV-1974: Refactor network events to return list of maps instead of strings Nov 26, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 26, 2024

@msherif1234: This pull request references NETOBSERV-1974 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Description

Network events was orignally decode as string with this recent ovnk lib it will come as struct and the agent need to generate list of configmaps with those events
this effort to allow generating metrics with network events

Dependencies

ovn-kubernetes/ovn-kubernetes#4818

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 02d1817 into netobserv:main Nov 26, 2024
13 checks passed
@msherif1234 msherif1234 deleted the network_events_struct branch November 26, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/valid-reference lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants