feat: do not process if commands[i] is func type #3200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blmarket
force-pushed
the
feature-raw-commands
branch
from
69966cd
to
3732f0b
Compare
|
lint fix. |
To pass it as-is to the vim.lsp.start_client argument
blmarket
force-pushed
the
feature-raw-commands
branch
from
3732f0b
to
ec5e2af
Compare
blmarket
changed the title
|
Hello, can I get review again? |
elijah-potter
pushed a commit
to elijah-potter/nvim-lspconfig
that referenced
this pull request
Jul 25, 2024
To pass it as-is to the vim.lsp.start_client argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #3087 (comment)
I want to set commands argument in vim.lsp.ClientConfig which has
table<string, fun>type, which is not conforming to lspconfig's own commands type. lspconfig has to skip them for user command registrations.