Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cloudflare accountId option to the generator schema #14

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

NachoVazquez
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The accountId is necessary for deploying the worker, and we are not providing an option to define it.

What is the new behavior?

We define the accountId on the schema, and if present we added the account_id to the wrangler.toml

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@NachoVazquez NachoVazquez merged commit 4f11eb9 into main Aug 7, 2023
8 checks passed
@NachoVazquez NachoVazquez deleted the feat/add-account-id-option-for-generator branch August 7, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant