-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gauge Plugin] Fix Missing Object handling #7923
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7923 +/- ##
==========================================
- Coverage 57.66% 57.43% -0.23%
==========================================
Files 677 677
Lines 27373 27375 +2
Branches 2689 2690 +1
==========================================
- Hits 15784 15724 -60
- Misses 11250 11310 +60
- Partials 339 341 +2
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…enmct into gauge-missing-object-fix mergin
Should we use telemetry collection here for gauges? |
Yes, but not for this one! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
Closes #7908
Describe your changes:
Don't make requests if there's no metadata.
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist