-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use the npm workspace packages/*
pattern and rename e2e subpackage
#7916
Draft
ozyx
wants to merge
12
commits into
master
Choose a base branch
from
prepare-openmct-e2e-subpackage
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,117
−1,167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubpackage - renames e2e subpackage from openmct-e2e to @openmct/e2e (uses openmct project scope)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7916 +/- ##
==========================================
- Coverage 57.66% 57.14% -0.53%
==========================================
Files 677 677
Lines 27373 27373
Branches 2689 2689
==========================================
- Hits 15786 15643 -143
- Misses 11248 11388 +140
- Partials 339 342 +3
see 17 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
- When others install and use `@openmct/e2e`, playwright and other testing tools should come along with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7918
Describe your changes:
This PR reorganizes the e2e testing infrastructure by moving it into a proper npm workspace package. The changes are primarily structural and do not modify the functionality of the tests themselves. The purpose is to completely prepare our e2e testing framework for publication as a separate package, and update our usage of npm workspaces to have a maintainable structure that can be expanded upon in the future.
Key changes include:
/e2e
to/packages/e2e
@openmct/e2e
packageAll Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist