Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump references to support node22 #7901

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Bump references to support node22 #7901

merged 3 commits into from
Oct 18, 2024

Conversation

unlikelyzero
Copy link
Collaborator

@unlikelyzero unlikelyzero commented Oct 18, 2024

Closes #7900

Describe your changes:

Bumps node to 22

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@unlikelyzero unlikelyzero added type:maintenance tests, chores, or project maintenance notable_change A change which should be noted in the changelog labels Oct 18, 2024
@unlikelyzero unlikelyzero added this to the Target:4.1.0 milestone Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.42%. Comparing base (518b55c) to head (960545a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7901      +/-   ##
==========================================
- Coverage   57.57%   57.42%   -0.16%     
==========================================
  Files         676      676              
  Lines       27370    27370              
  Branches     2688     2688              
==========================================
- Hits        15759    15717      -42     
- Misses      11271    11313      +42     
  Partials      340      340              
Flag Coverage Δ
e2e-ci 62.45% <ø> (-0.01%) ⬇️
e2e-full 41.81% <ø> (-9.72%) ⬇️
unit 49.30% <ø> (-0.02%) ⬇️

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 518b55c...960545a. Read the comment docs.

Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 18, 2024
@ozyx ozyx enabled auto-merge (squash) October 18, 2024 17:01
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 18, 2024
@ozyx ozyx merged commit 078cd34 into master Oct 18, 2024
36 checks passed
@ozyx ozyx deleted the bump-node-22 branch October 18, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notable_change A change which should be noted in the changelog type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Build] Bump node22
2 participants