-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vipergc-660): identify axis keys upon adding object to composition #7897
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7897 +/- ##
==========================================
+ Coverage 57.12% 57.44% +0.31%
==========================================
Files 676 676
Lines 27357 27370 +13
Branches 2685 2688 +3
==========================================
+ Hits 15627 15722 +95
+ Misses 11392 11308 -84
- Partials 338 340 +2
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change.
yKey = arrayValues.length > 1 ? arrayValues[1].key : yAxisMetadata.key; | ||
} else if (nonArrayValues.length > 0) { | ||
xKey = nonArrayValues[0].key; | ||
yKey = yAxisMetadata ? yAxisMetadata.key : 'none'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The yKey
is irrelevant when we're using nonArrayValues. Change this to:
yKey = 'none';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving - please make the change and merge.
Closes VIPERGC-660
Describe your changes:
Fixes an issue causing Graphs to not plot any data until the "Config" inspector tab was opened.
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist