Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vipergc-660): identify axis keys upon adding object to composition #7897

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Oct 17, 2024

Closes VIPERGC-660

Describe your changes:

Fixes an issue causing Graphs to not plot any data until the "Config" inspector tab was opened.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@shefalijoshi shefalijoshi added this to the Build 9 RC11 milestone Oct 17, 2024
@shefalijoshi shefalijoshi changed the title fix(vipergc-660: identify axis keys upon adding object to composition fix(vipergc-660): identify axis keys upon adding object to composition Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 57.44%. Comparing base (3e23dce) to head (6777c76).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/plugins/charts/bar/BarGraphView.vue 57.14% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7897      +/-   ##
==========================================
+ Coverage   57.12%   57.44%   +0.31%     
==========================================
  Files         676      676              
  Lines       27357    27370      +13     
  Branches     2685     2688       +3     
==========================================
+ Hits        15627    15722      +95     
+ Misses      11392    11308      -84     
- Partials      338      340       +2     
Flag Coverage Δ
e2e-ci 62.47% <ø> (+<0.01%) ⬆️
e2e-full 41.80% <ø> (+18.34%) ⬆️
unit 49.30% <57.14%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
src/plugins/charts/bar/BarGraphView.vue 62.84% <57.14%> (+2.25%) ⬆️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e23dce...6777c76. Read the comment docs.

Copy link
Contributor

@shefalijoshi shefalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change.

yKey = arrayValues.length > 1 ? arrayValues[1].key : yAxisMetadata.key;
} else if (nonArrayValues.length > 0) {
xKey = nonArrayValues[0].key;
yKey = yAxisMetadata ? yAxisMetadata.key : 'none';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yKey is irrelevant when we're using nonArrayValues. Change this to:
yKey = 'none';

Copy link
Contributor

@shefalijoshi shefalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving - please make the change and merge.

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 17, 2024
@ozyx ozyx enabled auto-merge (squash) October 17, 2024 21:56
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 17, 2024
@ozyx ozyx merged commit 518b55c into master Oct 17, 2024
21 checks passed
@ozyx ozyx deleted the vipergc-660 branch October 17, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants