fix: Migrate to Rails 5.2 #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
built-in method
Conflicts: README.md lib/generators/ratyrate/templates/ratyrate.js.erb lib/ratyrate/helpers.rb
add db:migrate to README, fix inconsistent capitalization
Fix rating_for_user
fix stars not display with turbolinks
Small fixes to make STI working correctly
* `:through` values should be symbols (see https://github.com/rails/rails/blob/4-1-stable/activerecord/lib/active_record/reflection.rb#L25), * this was causing errors in ActiveAdmin.
Fix error when reflecting on associations.
data-cancel should be treated as boolean value, not string
waffle.io Badge
Fix jquery.raty.js not found error
Fix typos in README.md
Change image path for gem's view helpers
Fix assets URLs
Fix to work with STI in Rails
Changes on lines 727,728, 748,749 and 750
Original
cancelOff : '<%= asset_path('cancel-off.png') %>',
cancelOn : '<%= asset_path('cancel-on.png') %>',
Changed
cancelOff : '<%= asset_path("cancel-off.png") %>',
cancelOn : '<%= asset_path("cancel-on.png") %>',
Update jquery.raty.js.erb
Activates readonly option
Add foreign key indices to the migration Ref: http://rails-bestpractices.com/posts/2010/07/24/always-add-db-index
Trigger an event (rated) when there is a new rating Docs needs to be updated later on
Also removes CoderWall endorsement counter
Updated jquery-rails version to `>= 4.3.1`
Update dependencies version
Fix rate_for_user recognizes wrong rateable_type for polymorphic
* Added migration version to handle 'Directly inheriting from ActiveRecord::Migration is not supported', this error * removed unused else condition when rails version is less than 5 for migration_version
fix: Migrate to Rails 5.2 and fix all migration conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.