Merge pull request #78 from multiparty/feat/optimize_shamirs

refactor: reduce number of shares generated to improve performance
multiparty · May 1, 2023 · bd4f0e3 · bd4f0e3
2 parents 551a538 + 9fe1b1a
commit bd4f0e3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/client/src/pages/home.tsx b/client/src/pages/home.tsx
@@ -21,8 +21,8 @@ export const HomePage: FC = () => {
   const [file, setFile] = useState<CustomFile | null>(null);
   const [data, setData] = useState<DataFormat>(defaultData);
   const [submitResp, setSubmitResp] = useState<AxiosResponse | undefined>();
-  const [numShares, setNumShares] = useState<number>(10);
-  const [threshold, setTheshold] = useState<number>(5); // Must have at least 5 shares to reconstruct
+  const [numShares, setNumShares] = useState<number>(3);
+  const [threshold, setTheshold] = useState<number>(1); // Must have at least 1 share to reconstruct
   const [numEncryptWithKey, setNumEncryptWithKey] = useState<number>(threshold + 1); // Encrypt amount "theshold + 1" shares with key
   const [table, setTable] = useState<Record<string, any>>({});
   const { companySize, industry, participantCode, sessionId, privateKey } = useSelector((state: AppState) => state.session);

diff --git a/client/src/utils/shamirs.ts b/client/src/utils/shamirs.ts
@@ -233,7 +233,6 @@ export async function tableToSecretShares(
 ): Promise<Record<string, any>> {
   const dfs = async (currentObj: Record<string, any>, originalObj: Record<string, any>): Promise<Record<string, any>> => {
     const keys = Object.keys(originalObj);
-    const encoder = new TextEncoder();
 
     for (const key of keys) {
       if (typeof originalObj[key] === 'number') {
@@ -289,7 +288,6 @@ export async function secretSharesToTable(
   }
   const dfs = async (currentObj: Record<string, any>, originalObj: Record<string, any>): Promise<Record<string, any>> => {
     const keys = Object.keys(originalObj);
-    const encoder = new TextEncoder();
 
     for (const key of keys) {
       if (Array.isArray(originalObj[key])) {