Add feature to convert from condition to ifdef. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is pull-request from my feature branch to development branch.
I implemented the feature from condition from ifdef.
asciidoctor#43
I have not checked for all the possible nodes yet. it must be many cases.
I thought I would share my code in this timing, to adjust my implementation with you.
My concern is below method. The method is reading entire lines.
However I did not have any other better idea than this, right now.
lib/docbookrx/docbook_visitor.rb#after
Could you check my code? I like to hear your opinion.
Thanks.