Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color aggregate lines the same across versions #631

Open
wants to merge 4 commits into
base: gh-pages
Choose a base branch
from

Conversation

jonco3
Copy link

@jonco3 jonco3 commented Nov 4, 2019

At present it can be confusing looking at evolution graphs because the individual aggregates get assigned different line colors for different versions, e.g.:

Screenshot_2019-11-04 Evolution Dashboard

I'm not sure whether that's exactly what this issue is talking about but it may be: #625

These changes fix this by removing the version component from Line.getStateString and renaming it to Line.getColorId (this is the only use of that method).

@chutten
Copy link
Contributor

chutten commented Nov 8, 2019

I do indeed believe that this is #625

We might not wish to do this for the submission date view, as the same submission date can have multiple versions (the same x value can have multiple data points) for a single aggregate. See, for instance this.

How bad would it look in the code if we only turned to this mode for submission date view?

Copy link
Contributor

@chutten chutten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know what you think about my earlier comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants