Add configuration options for net/http timeouts #229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These timeouts should be tuneable for users who don't want to limit downstream services to only accept fast responses.
Address #228 by providing the option to increase the write timeout.
@codedge can you give this a review and see if it addresses your issue, it wasn't able to be configured by the
limits
plugin as it's themain
method that sets up thehttp.Server
instances.In the
config.json
you can either provide adefault-timeouts
map ofread
,write
andidle
keys that will be used for all thehttp.Server
instances or override the defaults withgateway-timeouts
andprivate-timeouts
maps that only need to provide values differing from the defaults.