Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consensus and axiom events #241

Merged
merged 18 commits into from
Jan 31, 2020
Merged

Consensus and axiom events #241

merged 18 commits into from
Jan 31, 2020

Conversation

jayeshbairagi
Copy link
Collaborator

@jayeshbairagi jayeshbairagi commented Jan 29, 2020 •
edited
Loading

This PR implements:

  • Axiom::MetachainCreated event
  • Consensus::CoreCreated event
  • Consensus::CoreLifetimeUpdated event
  • Consensus::ValidatorJoined event
  • Consensus::ValidatorLoggedOut event
  • Consensus::MetablockPrecommitted event
  • Consensus::MetablockCommitteeFormed event
  • Consensus::MetablockCommitteeDecided event
  • Consensus::MetablockCommitted event

Ref: Validator transaction handlers

Fixes #195

@abhayks1 abhayks1 self-assigned this Jan 29, 2020
abhayks1
abhayks1 previously requested changes Jan 29, 2020
View reviewed changes
Copy link
Collaborator

@abhayks1 abhayks1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comment below.
Few events needs changes

contracts/axiom/Axiom.sol Outdated Show resolved Hide resolved
contracts/consensus/Consensus.sol Show resolved Hide resolved
contracts/consensus/Consensus.sol Outdated Show resolved Hide resolved
contracts/consensus/Consensus.sol Outdated Show resolved Hide resolved
contracts/consensus/Consensus.sol Outdated Show resolved Hide resolved
contracts/reputation/Reputation.sol Outdated Show resolved Hide resolved
contracts/reputation/Reputation.sol Outdated Show resolved Hide resolved
contracts/reputation/ReputationI.sol Outdated Show resolved Hide resolved
contracts/test/committee/CommitteeMockConsensus.sol Outdated Show resolved Hide resolved
contracts/test/committee/SpyCommittee.sol Outdated Show resolved Hide resolved
@abhayks1 abhayks1 removed their assignment Jan 29, 2020
jayeshbairagi
jayeshbairagi commented Jan 29, 2020
View reviewed changes
Copy link
Collaborator Author

@jayeshbairagi jayeshbairagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed feedback changes

contracts/consensus/Consensus.sol Show resolved Hide resolved
contracts/consensus/Consensus.sol Show resolved Hide resolved
contracts/consensus/Consensus.sol
@@ -574,7 +656,7 @@ contract Consensus is MasterCopyNonUpgradable, CoreLifetimeEnum, MosaicVersion,
uint256 _sourceBlockHeight,
uint256 _targetBlockHeight
)
external
public
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the Stack too deep error

contracts/consensus/ConsensusI.sol Outdated Show resolved Hide resolved
@deepesh-kn deepesh-kn self-assigned this Jan 31, 2020
deepesh-kn
deepesh-kn suggested changes Jan 31, 2020
View reviewed changes
Copy link
Collaborator

@deepesh-kn deepesh-kn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Till now looks good to me.
I am assuming that when we progress more there can be few changes.

contracts/axiom/Axiom.sol Outdated Show resolved Hide resolved
contracts/consensus/Consensus.sol
@@ -574,7 +656,7 @@ contract Consensus is MasterCopyNonUpgradable, CoreLifetimeEnum, MosaicVersion,
uint256 _sourceBlockHeight,
uint256 _targetBlockHeight
)
external
public
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a followup ticket to make it external.

@deepesh-kn deepesh-kn removed their assignment Jan 31, 2020
@deepesh-kn deepesh-kn merged commit cfedd4e into mosaicdao:develop Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepesh-kn deepesh-kn deepesh-kn approved these changes

@abhayks1 abhayks1 abhayks1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update events for the Consensus and Axiom contract
4 participants
@jayeshbairagi @abhayks1 @deepesh-kn @kreloaded