-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDL-77353 Functions for generating and displaying user details #634
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for moodledevdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @tuanngocnguyen. This needs some more changes before we can merge this to the dev docs. Please see the review comments.
Thanks!
|
||
## Functions for generating and displaying user details | ||
|
||
#### `core_user::get_profile_picture` for retrieving user picture. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use lists for the methods instead of headings.
Also, something to remember for the future: For accessibility reasons, headings must increase by one level. e.g. an h2
heading needs to have an h3
heading underneath it.
@@ -9,3 +9,9 @@ tags: | |||
import { CodeBlock, CodeExample, InvalidExample, ValidExample } from '@site/src/components'; | |||
|
|||
This page highlights the important changes that are coming in Moodle 4.3 for developers. | |||
|
|||
## Functions for generating and displaying user details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A more appropriate heading would be something like "User-related API updates", then followed by a paragraph that describes the update. e.g. "New functions for generating and displaying user details have been created:", then followed by the list of the new user functions.
@tuanngocnguyen apart from the comments raised by Jun, these changes should be moved now to versioned_docs/version-4.3/devupdate.md (because the current docs/devupdate.md is for changes in 4.4 :-) ). |
Update doc due to changes in
https://tracker.moodle.org/browse/MDL-77353