Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message for attaching game log #196

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

Marcono1234
Copy link
Contributor

Also resolves #133

Any feedback is appreciated!

Have marked this as Draft for now because I am not sure if we should use the MinecraftHopper articles for getting the latest logs or copying the game output.
Both currently recommend to use https://paste.gg/ and to include the Discord username, which probably overcomplicates it for our Mojira usecase. Additionally copying the game output directly from the launcher window seems a bit error-prone to me. What do you think?

Copy link
Member

@osfanbuff63 osfanbuff63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should say that it shouldn't be marked to expire (expires: unlimited) since that could potentially cause issues with people looking at it later. Also, should the minecraft data folder be the .minecraft folder?

@Marcono1234
Copy link
Contributor Author

Maybe we should say that it shouldn't be marked to expire (expires: unlimited)

Do you mean for https://paste.gg/? My main concern is that it is a third-party site and overcomplicates it. Maybe for the Community Support Discord, for which I assume the MinecraftHopper articles are mainly intended, this approach is the easiest one. But for Mojira I think directly attaching the file is the easiest solution. That avoids having the user copy the file content, which could lead to incomplete log file contents.

Also, should the minecraft data folder be the .minecraft folder?

Apparently for macOS it is ~/Library/Application Support/minecraft (without .), but maybe the current phrase in the new message is not ideal.

@violine1101
Copy link
Member

Hmm. The guides at minecrafthopper.net are good, but yeah they don't quite fit the Mojira usecase.

Maybe the easiest way to solve this is to create new guides for Mojira specifically (based on the minecrafthopper guides of course). I'm thinking of filing WEB tickets for those (which would be resolved as Invalid), that way they can also be edited easily if necessary.

Apart from that I'd love to get this PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Attach crash report" message should mention where to find game logs
3 participants