Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add JSX, GWT, SharpNative, Babel.js #6

Merged
merged 2 commits into from
Sep 18, 2016

Conversation

waldyrious
Copy link
Contributor

@waldyrious waldyrious commented Sep 8, 2016

The GWT link could be the more specific http://www.gwtproject.org/doc/latest/DevGuideCompilingAndDebugging.html#DevGuideJavaToJavaScriptCompiler, but I'm not sure if such deep links fit well with the current ones (see #3 for a similar question).

The GWT link could be the more specific http://www.gwtproject.org/doc/latest/DevGuideCompilingAndDebugging.html#DevGuideJavaToJavaScriptCompiler, but I'm not sure if such deep links fit well with the current ones.
@mohd-akram
Copy link
Owner

GWT and SharpNative are fine. However, you seem to have included two different types of JSX, the Facebook one and a statically typed version of JavaScript. I think neither of those is fit for this list as the former is too domain-specific and the latter doesn't seem to be widely used. The link that you have used for GWT is fine, I think shorter links are nicer.

@waldyrious
Copy link
Contributor Author

However, you seem to have included two different types of JSX, the Facebook one and a statically typed version of JavaScript.

Oops, I didn't realize they weren't the same. Turns out I'm not the only one: jsx/JSX#305.

I'll remove both, then.

Copy link
Owner

@mohd-akram mohd-akram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@mohd-akram mohd-akram merged commit 68a953e into mohd-akram:develop Sep 18, 2016
@mohd-akram
Copy link
Owner

Haha, not surprising!

@waldyrious waldyrious deleted the patch-1 branch September 18, 2016 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants