Make YoungAndroidPalettePanel a singleton #3170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a YaFormEditor or a YaBlocksEditor takes roughly between 250-300 ms on a relatievly powerful laptop. Most of this time is spent in constructing the YoungAndroidPalettePanel (which the YaBlocksEditor doesn't even make use of). This change makes it so that there is a single YoungAndroidPalettePanel that uses a model-view-controller approach to render the current editor's component database rather than constructing an instance per-editor. This reduces the creation of editors down to around 10 ms or less. Change-Id: I8cd301384afd673ff870664dcb1d5698e200e9ea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance improvement by @ewpatton:
Creating a YaFormEditor or a YaBlocksEditor takes roughly between 250-300 ms on a relatievly powerful laptop. Most of this time is spent in constructing the YoungAndroidPalettePanel (which the YaBlocksEditor doesn't even make use of). This change makes it so that there is a single YoungAndroidPalettePanel that uses a model-view-controller approach to render the current editor's component database rather than constructing an instance per-editor. This reduces the creation of editors down to around 10 ms or less.
Change-Id: I8cd301384afd673ff870664dcb1d5698e200e9ea