Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name of application #475

Merged
merged 3 commits into from
Jul 28, 2024
Merged

Fix name of application #475

merged 3 commits into from
Jul 28, 2024

Conversation

ramondeklein
Copy link
Contributor

I guess the name of the application should be kes everywhere.

@ramondeklein ramondeklein self-assigned this Jul 15, 2024
@ramondeklein ramondeklein requested a review from aead July 15, 2024 15:25
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please check the build failures.

Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer os.Args[0] but this is acceptable

@ramondeklein
Copy link
Contributor Author

@harshavardhana I do to, but I wanted to bring it inline with the rest of the application. Search for $ kes and there are lots of references. Just wanted to fix this incorrect one.

@ramondeklein
Copy link
Contributor Author

@harshavardhana Can you merge. I'm not allowed to...

@klauspost
Copy link
Contributor

@ramondeklein Seems like CI needs a version bump :/

@ramondeklein
Copy link
Contributor Author

@klauspost I'll know how to do that 😉

@ramondeklein
Copy link
Contributor Author

@klauspost Can you merge?

@ramondeklein
Copy link
Contributor Author

@aead Can you merge?

@aead aead merged commit c1fa6dc into minio:master Jul 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants