Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Join with readonly arrays #259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Join with readonly arrays #259

wants to merge 1 commit into from

Conversation

DetachHead
Copy link

🎁 Pull Request

  • Used a clear / meaningful title for this pull request
  • Tested the changes in your own code (on your projects)
  • Added / Edited tests to reflect changes (tests folder)
  • Have read the Contributing part of the Readme
  • Passed npm test

Fixes

fixes #258

Why have you made changes?

Join didn't work with readonly arrays

What changes have you made?

  • added readonly keyword to arrays checked by the _Join conditional type

What tests have you updated?

  • JOIN in tests/String.ts

Is there any breaking changes?

  • Yes, I changed the public API & documented it
  • Yes, I changed existing tests
  • No, I added to the public API & documented it
  • No, I added to the existing tests
  • I don't know

Anything else worth mentioning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millsp millsp Awaiting requested review from millsp millsp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Join doesn't work on readonly arrays
1 participant
@DetachHead