Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a custom agent to be passed in #99

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

CliffS
Copy link

@CliffS CliffS commented Apr 19, 2020

This change allows a custom agent to be passed into the call to bent(). It will permit proxying both by use of a local proxy or a remote proxy. There may be other uses that can make use of a custom agent.

I have added one test via a squid server set up only to work against the usual test server.

@CliffS
Copy link
Author

CliffS commented May 18, 2020

@mikeal Do you dislike the principle behind this PR? If so I'll delete it.

@CliffS
Copy link
Author

CliffS commented Aug 11, 2020

@mikeal Please advise whether you want this PR, in which case I'll update it, or if you don't, in which case I'll simply close it.

Thanks.

Bring my version up to date with master.
@CliffS
Copy link
Author

CliffS commented May 19, 2021

Closing this PR owing to a lack of interest.

@Niklas-Dahlquist
Copy link

Can this topic be reopened? Would appreciate if proxies could be respected with bent

@CliffS
Copy link
Author

CliffS commented Oct 15, 2021

Can this topic be reopened? Would appreciate if proxies could be respected with bent

I'm happy to bring this up to date. But only if @mikeal wants it.

@Niklas-Dahlquist
Copy link

Can this topic be reopened? Would appreciate if proxies could be respected with bent

I'm happy to bring this up to date. But only if @mikeal wants it.

@mikeal Do you agree to this topic?

@SalAlba
Copy link

SalAlba commented Oct 27, 2023

................................................................................................
TypeError: Cannot convert object to primitive value
at RegExp.exec ()
at checkInvalidHeaderChar (node:_http_common:224:10)
at _node_internal (node:_http_outgoing:626:7)
at ClientRequest.setHeader (node:_http_outgoing:651:3)
at new ClientRequest (node:_http_client:291:14)
at Object.request (node:https:358:10)
at C:\node-sandbox\4-pro\node_modules\bent\src\nodejs.js:127:19
at new Promise ()
at C:\node-sandbox\4-pro\node_modules\bent\src\nodejs.js:126:10
at testMicrosoftTts (C:\node-sandbox\4-pro\testMicrosoftTts.js:46:32)
Cannot convert object to primitive value
................................................................................................

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants