Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Firestore Rules, Update Packages #337

Draft
wants to merge 12 commits into
base: dev
Choose a base branch
from
Draft

Update Firestore Rules, Update Packages #337

wants to merge 12 commits into from

Conversation

mikaelacaron
Copy link
Owner

@mikaelacaron mikaelacaron commented Oct 10, 2024 •
edited
Loading

What it Does

  • Update Firestore rules in the docs and the emulator to only be able to edit your own data and not others
  • Update packages (Firebase version 11+)
  • Remove deprecated libraries
    • FirebaseRemoteConfigSwift
    • FirebaseAnalyticsSwift
    • FirebaseFirestoreSwift

How I Tested

  • App still works to add a vehicle, maintenance event, and odometer reading

Notes

Screenshot

N/A

@mikaelacaron
Copy link
Owner Author

Firebase is updated, and rules are written in docs, but on this branch the read write is failing, even when the rules are open with allow read, write: if true;, which could be a bug with Firebase? I'll merge this after chatting with Firebase support

@mikaelacaron mikaelacaron added the hacktoberfest-accepted Accepted PR for Hacktoberfest label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted PR for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mikaelacaron