Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - To be merged for 7.1 MTA-4016: Analyzer task RBAC #73

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

anarnold97
Copy link
Collaborator

@anarnold97 anarnold97 commented Nov 25, 2024

JIRA

There is some discussion about whether the warning should contain the example, e.g:

[WARNING]
.No multi-user access restrictions on resources
====
There are no multi-user access restrictions on resources.
An analyzer task created by a user, can be canceled by any other user.
====

Ilanit prefers without and Maayan prefers with. I am undecided

PREVIEW

Snippet
image

Following Ilanit's comments, I have added the snippet to the top level of each book in the MTA docs:

@anarnold97
Copy link
Collaborator Author

anarnold97 commented Nov 25, 2024

@mguetta1 - please can you have a look, as i am not sure what else to add to the snippet, or where else this should be added?
Thanks

====
There are no multi-user access restrictions on resources.

An analyzer task created by a user, can be canceled by any other user.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to remove the specific example of analyzer task access,
as we have the no multi-user access restriction on other resources as well.
Just leave the ".No multi-user access restrictions on resources" warning
and place it in the head of the MTA doc.

Signed-off-by: A.Arnold <[email protected]>
Copy link
Collaborator

@mguetta1 mguetta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anarnold97 thanks for this PR.
Could you please add this as a known issue rather than snippet?
And I am not sure about including this information in all the files here. From my point of view, I would like to see it as a known issue with the example that "An analyzer task created by a user, can be canceled by any other use" as a result

@anarnold97
Copy link
Collaborator Author

@anarnold97 thanks for this PR. Could you please add this as a known issue rather than snippet? And I am not sure about including this information in all the files here. From my point of view, I would like to see it as a known issue with the example that "An analyzer task created by a user, can be canceled by any other use" as a result

@mguetta1 - i will add as a Known Issue in another PR, so we are not relying on the readers looking at the release notes. See - MTA-4014: Custom rules in analysis Dependency rule is not fired

@anarnold97 anarnold97 changed the title Mta 4016 analyzer task rbac MTA-4016: Analyzer task RBAC Nov 26, 2024
@anarnold97 anarnold97 changed the title MTA-4016: Analyzer task RBAC WIP - To be merged for 7.1 MTA-4016: Analyzer task RBAC Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants