-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - To be merged for 7.1 MTA-4016: Analyzer task RBAC #73
base: main
Are you sure you want to change the base?
Conversation
…ccess control issue) Signed-off-by: A.Arnold <[email protected]>
Signed-off-by: A.Arnold <[email protected]>
@mguetta1 - please can you have a look, as i am not sure what else to add to the snippet, or where else this should be added? |
==== | ||
There are no multi-user access restrictions on resources. | ||
|
||
An analyzer task created by a user, can be canceled by any other user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to remove the specific example of analyzer task access,
as we have the no multi-user access restriction on other resources as well.
Just leave the ".No multi-user access restrictions on resources" warning
and place it in the head of the MTA doc.
Signed-off-by: A.Arnold <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anarnold97 thanks for this PR.
Could you please add this as a known issue rather than snippet?
And I am not sure about including this information in all the files here. From my point of view, I would like to see it as a known issue with the example that "An analyzer task created by a user, can be canceled by any other use" as a result
@mguetta1 - i will add as a Known Issue in another PR, so we are not relying on the readers looking at the release notes. See - MTA-4014: Custom rules in analysis Dependency rule is not fired |
JIRA
There is some discussion about whether the warning should contain the example, e.g:
Ilanit prefers without and Maayan prefers with. I am undecided
PREVIEW
Following Ilanit's comments, I have added the snippet to the top level of each book in the MTA docs: