-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To be merged for 7.1 - MTA-3848: MTA flags are missing in the documentation #69
base: main
Are you sure you want to change the base?
To be merged for 7.1 - MTA-3848: MTA flags are missing in the documentation #69
Conversation
Signed-off-by: A.Arnold <[email protected]>
Signed-off-by: A.Arnold <[email protected]>
Signed-off-by: A.Arnold <[email protected]>
Signed-off-by: A.Arnold <[email protected]>
Co-authored-by: Mariya Pershina <[email protected]>
Co-authored-by: Mariya Pershina <[email protected]>
Co-authored-by: Mariya Pershina <[email protected]>
Co-authored-by: Mariya Pershina <[email protected]>
Co-authored-by: Mariya Pershina <[email protected]>
Co-authored-by: Mariya Pershina <[email protected]>
Co-authored-by: Mariya Pershina <[email protected]>
Co-authored-by: Mariya Pershina <[email protected]>
Co-authored-by: Mariya Pershina <[email protected]>
Co-authored-by: Mariya Pershina <[email protected]>
Co-authored-by: Mariya Pershina <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do a list of technology tags
expandable? It takes a long time to scroll through this list :-)
@ibragins - I am not sure what you mean by "technology tags expandable", do you mean a collapsible block In which case YEAH OF COURSE:
it is like i know what i am doing sometimes |
@anarnold97 sorry, I meant collapsible block. And didn't want to offend you in any way. |
@ibragins - no worries, |
Take care @anarnold97 , and don't damage your laptop with your coffee :-D |
Signed-off-by: A.Arnold <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave it a quick look with few comments.
Note, current flags (for 7.2.0) of the CLI tool should be following:
kantra$ go run main.go analyze --help
Analyze application source code
Usage:
kantra analyze [flags]
Flags:
--analyze-known-libraries analyze known open-source libraries
--bulk running multiple analyze commands in bulk will result to combined static report
--context-lines int number of lines of source code to include in the output for each incident (default 100)
-d, --dependency-folders stringArray directory for dependencies
--enable-default-rulesets run default rulesets with analysis (default true)
-h, --help help for analyze
--http-proxy string HTTP proxy string URL
--https-proxy string HTTPS proxy string URL
--incident-selector string an expression to select incidents based on custom variables. ex: (!package=io.konveyor.demo.config-utils)
-i, --input string path to application source code or a binary
--jaeger-endpoint string jaeger endpoint to collect traces
--json-output create analysis and dependency output as json
-l, --label-selector string run rules based on specified label selector expression
--list-providers list available supported providers
--list-sources list rules for available migration sources
--list-targets list rules for available migration targets
--maven-settings string path to a custom maven settings file to use
-m, --mode string analysis mode. Must be one of 'full' (source + dependencies) or 'source-only' (default "full")
--no-proxy string proxy excluded URLs (relevant only with proxy)
-o, --output string path to the directory for analysis output
--override-provider-settings string override the provider settings, the analysis pod will be run on the host network and no providers will be started up
--overwrite overwrite output directory
--provider stringArray specify which provider(s) to run
--rules stringArray filename or directory containing rule files. Use multiple times for additional rules: --rules <rule1> --rules <rule2> ...
--run-local run analysis directly on local system without containers (for Java and Maven)
--skip-static-report do not generate static report
-s, --source stringArray source technology to consider for analysis. Use multiple times for additional sources: --source <source1> --source <source2> ...
-t, --target stringArray target technology to consider for analysis. Use multiple times for additional targets: --target <target1> --target <target2> ...
Global Flags:
--log-level uint32 log level (default 4)
--no-cleanup do not cleanup temporary resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For diff, check konveyor/kantra@release-0.5...release-0.6 and focus on files in But depends if the previous release docs were up-to-date. |
@ibragins - please could you do a review, when you have a chance? as i would like to get it merged for 7.1 ASAP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
==== | ||
|
||
//// | ||
[id="cli-packages-argument_{context}"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
||
| -s, --source string | ||
| source technology to consider for analysis. To specify multiple sources, repeat the parameter: --source <source_1> --source <source_2> etc. | ||
a|`--run-local` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just note, this is default true
in 7.2, can be disabled with --run-local=false
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn it! Will have to do a second PR for that
JIRA
PREVIEW
While fixing a build problem, I found an open block comment that had removed the following section of documentation. Is it required (including amended) or is it to be removed?