Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup unused files in .github #189066

Merged
merged 1 commit into from
Oct 5, 2023
Merged

cleanup unused files in .github #189066

merged 1 commit into from
Oct 5, 2023

Conversation

Jvr2022
Copy link
Contributor

@Jvr2022 Jvr2022 commented Jul 27, 2023

I have removed:

calender.yml. the The dates have not been updated since 2018
subscribers.json. there is nothing in the file.

i have removed
calender.yml. the The dates have not been updated since 2018
subscribers.json. there is nothing in the file.
@AdamRaichu
Copy link

Is subscribers the file referenced here? I can't tell.

# only here.
- name: Run Subscribers
uses: ./actions/topic-subscribe
with:
appInsightsKey: ${{secrets.TRIAGE_ACTIONS_APP_INSIGHTS}}
token: ${{secrets.VSCODE_ISSUE_TRIAGE_BOT_PAT}}
config-path: subscribers

@Jvr2022
Copy link
Contributor Author

Jvr2022 commented Jul 28, 2023

Is subscribers the file referenced here? I can't tell.

# only here.
- name: Run Subscribers
uses: ./actions/topic-subscribe
with:
appInsightsKey: ${{secrets.TRIAGE_ACTIONS_APP_INSIGHTS}}
token: ${{secrets.VSCODE_ISSUE_TRIAGE_BOT_PAT}}
config-path: subscribers

I don't know why it gets still used there is nothing more in the file

@vscodenpa vscodenpa added this to the August 2023 milestone Aug 22, 2023
@rebornix rebornix modified the milestones: August 2023, September 2023 Aug 31, 2023
@Jvr2022
Copy link
Contributor Author

Jvr2022 commented Sep 14, 2023

When this gets the next review?

@chrmarti chrmarti modified the milestones: September 2023, October 2023 Sep 27, 2023
@Jvr2022
Copy link
Contributor Author

Jvr2022 commented Oct 5, 2023

@rebornix thanks for approving the pull request

@TylerLeonhardt TylerLeonhardt merged commit eec8448 into microsoft:main Oct 5, 2023
4 checks passed
@TylerLeonhardt
Copy link
Member

Thanks for your contribution, @Jvr2022!

@Jvr2022
Copy link
Contributor Author

Jvr2022 commented Oct 5, 2023

@TylerLeonhardt thx for merging

@Jvr2022
Copy link
Contributor Author

Jvr2022 commented Oct 5, 2023

Can i help something others now? @TylerLeonhardt

@Jvr2022
Copy link
Contributor Author

Jvr2022 commented Oct 5, 2023

And can u help with reviewing 2 other pr @TylerLeonhardt

@TylerLeonhardt
Copy link
Member

@Jvr2022 looking at our "good first issues" query is a best place to look for more straightforward issues to pick up:
https://github.com/microsoft/vscode/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

If those PRs are already assigned, you'll need to wait for the folks who are assigned to review. We ask for patience as we have a lot on our plate and can't always move quickly to merge in PRs 🙏 hope you can understand

@Jvr2022
Copy link
Contributor Author

Jvr2022 commented Oct 5, 2023

Only vscode bot has assigned u 2 months ago @TylerLeonhardt

@TylerLeonhardt
Copy link
Member

I'll take a look as soon as I can 👍

@Jvr2022
Copy link
Contributor Author

Jvr2022 commented Oct 5, 2023

Thx this are the pull requests #189062 #189060

@lramos15
Copy link
Member

lramos15 commented Oct 5, 2023

Is subscribers the file referenced here? I can't tell.

# only here.
- name: Run Subscribers
uses: ./actions/topic-subscribe
with:
appInsightsKey: ${{secrets.TRIAGE_ACTIONS_APP_INSIGHTS}}
token: ${{secrets.VSCODE_ISSUE_TRIAGE_BOT_PAT}}
config-path: subscribers

Yeah this should've been removed as well when the file was removed as now the bot is throwing a bunch of errors. #194934 should remove this workflow

Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
i have removed
calender.yml. the The dates have not been updated since 2018
subscribers.json. there is nothing in the file.
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants